diff for duplicates of <1355002958.14981.11.camel@gitbox> diff --git a/a/1.txt b/N1/1.txt index 0709bf2..aea05f9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -56,14 +56,14 @@ On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote: > fbi->fb.pseudo_palette = addr; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -> - if (res = NULL) { +> - if (res == NULL) { > - dev_err(&pdev->dev, "no I/O memory resource defined\n"); > - ret = -ENODEV; > - goto failed_fbi; > - } > - > - res = request_mem_region(res->start, resource_size(res), DRIVER_NAME); -> - if (res = NULL) { +> - if (res == NULL) { > - dev_err(&pdev->dev, "failed to request I/O memory\n"); > - ret = -EBUSY; > - goto failed_fbi; @@ -71,7 +71,7 @@ On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote: > > - fbi->regbase = ioremap(res->start, resource_size(res)); > + fbi->regbase = devm_request_and_ioremap(&pdev->dev, res); -> if (fbi->regbase = NULL) { +> if (fbi->regbase == NULL) { > dev_err(&pdev->dev, "failed to map I/O memory\n"); > ret = -EBUSY; > - goto failed_free_res; @@ -157,7 +157,7 @@ On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote: > > _______________________________________________ > linux-arm-kernel mailing list -> linux-arm-kernel@lists.infradead.org +> linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Julia, diff --git a/a/content_digest b/N1/content_digest index b8c8a1b..df2b95c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01354984288-773-1-git-send-email-Julia.Lawall@lip6.fr\0" - "From\0Tony Prisk <linux@prisktech.co.nz>\0" - "Subject\0Re: [PATCH] drivers/video/wm8505fb.c: use devm_ functions\0" - "Date\0Sat, 08 Dec 2012 21:42:38 +0000\0" + "From\0linux@prisktech.co.nz (Tony Prisk)\0" + "Subject\0[PATCH] drivers/video/wm8505fb.c: use devm_ functions\0" + "Date\0Sun, 09 Dec 2012 10:42:38 +1300\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -63,14 +63,14 @@ "> \tfbi->fb.pseudo_palette\t= addr;\n" "> \n" "> \tres = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n" - "> -\tif (res = NULL) {\n" + "> -\tif (res == NULL) {\n" "> -\t\tdev_err(&pdev->dev, \"no I/O memory resource defined\\n\");\n" "> -\t\tret = -ENODEV;\n" "> -\t\tgoto failed_fbi;\n" "> -\t}\n" "> -\n" "> -\tres = request_mem_region(res->start, resource_size(res), DRIVER_NAME);\n" - "> -\tif (res = NULL) {\n" + "> -\tif (res == NULL) {\n" "> -\t\tdev_err(&pdev->dev, \"failed to request I/O memory\\n\");\n" "> -\t\tret = -EBUSY;\n" "> -\t\tgoto failed_fbi;\n" @@ -78,7 +78,7 @@ "> \n" "> -\tfbi->regbase = ioremap(res->start, resource_size(res));\n" "> +\tfbi->regbase = devm_request_and_ioremap(&pdev->dev, res);\n" - "> \tif (fbi->regbase = NULL) {\n" + "> \tif (fbi->regbase == NULL) {\n" "> \t\tdev_err(&pdev->dev, \"failed to map I/O memory\\n\");\n" "> \t\tret = -EBUSY;\n" "> -\t\tgoto failed_free_res;\n" @@ -164,7 +164,7 @@ "> \n" "> _______________________________________________\n" "> linux-arm-kernel mailing list\n" - "> linux-arm-kernel@lists.infradead.org\n" + "> linux-arm-kernel at lists.infradead.org\n" "> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel\n" "\n" "Julia,\n" @@ -222,4 +222,4 @@ "Regards\n" Tony P -44522e84ee3da653429f73334048a595790e897b53c4fe3a391e2f6389f427e3 +6db267c061010eda27129870d1488ede019d22d623b95e830139082802d768a4
diff --git a/a/1.txt b/N2/1.txt index 0709bf2..b72f36c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -56,14 +56,14 @@ On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote: > fbi->fb.pseudo_palette = addr; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -> - if (res = NULL) { +> - if (res == NULL) { > - dev_err(&pdev->dev, "no I/O memory resource defined\n"); > - ret = -ENODEV; > - goto failed_fbi; > - } > - > - res = request_mem_region(res->start, resource_size(res), DRIVER_NAME); -> - if (res = NULL) { +> - if (res == NULL) { > - dev_err(&pdev->dev, "failed to request I/O memory\n"); > - ret = -EBUSY; > - goto failed_fbi; @@ -71,7 +71,7 @@ On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote: > > - fbi->regbase = ioremap(res->start, resource_size(res)); > + fbi->regbase = devm_request_and_ioremap(&pdev->dev, res); -> if (fbi->regbase = NULL) { +> if (fbi->regbase == NULL) { > dev_err(&pdev->dev, "failed to map I/O memory\n"); > ret = -EBUSY; > - goto failed_free_res; diff --git a/a/content_digest b/N2/content_digest index b8c8a1b..18bf7e1 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,13 @@ "ref\01354984288-773-1-git-send-email-Julia.Lawall@lip6.fr\0" "From\0Tony Prisk <linux@prisktech.co.nz>\0" "Subject\0Re: [PATCH] drivers/video/wm8505fb.c: use devm_ functions\0" - "Date\0Sat, 08 Dec 2012 21:42:38 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Sun, 09 Dec 2012 10:42:38 +1300\0" + "To\0Julia Lawall <Julia.Lawall@lip6.fr>\0" + "Cc\0linux-fbdev@vger.kernel.org" + kernel-janitors@vger.kernel.org + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + " Florian Tobias Schandinat <FlorianSchandinat@gmx.de>\0" "\00:1\0" "b\0" "On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote:\n" @@ -63,14 +68,14 @@ "> \tfbi->fb.pseudo_palette\t= addr;\n" "> \n" "> \tres = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n" - "> -\tif (res = NULL) {\n" + "> -\tif (res == NULL) {\n" "> -\t\tdev_err(&pdev->dev, \"no I/O memory resource defined\\n\");\n" "> -\t\tret = -ENODEV;\n" "> -\t\tgoto failed_fbi;\n" "> -\t}\n" "> -\n" "> -\tres = request_mem_region(res->start, resource_size(res), DRIVER_NAME);\n" - "> -\tif (res = NULL) {\n" + "> -\tif (res == NULL) {\n" "> -\t\tdev_err(&pdev->dev, \"failed to request I/O memory\\n\");\n" "> -\t\tret = -EBUSY;\n" "> -\t\tgoto failed_fbi;\n" @@ -78,7 +83,7 @@ "> \n" "> -\tfbi->regbase = ioremap(res->start, resource_size(res));\n" "> +\tfbi->regbase = devm_request_and_ioremap(&pdev->dev, res);\n" - "> \tif (fbi->regbase = NULL) {\n" + "> \tif (fbi->regbase == NULL) {\n" "> \t\tdev_err(&pdev->dev, \"failed to map I/O memory\\n\");\n" "> \t\tret = -EBUSY;\n" "> -\t\tgoto failed_free_res;\n" @@ -222,4 +227,4 @@ "Regards\n" Tony P -44522e84ee3da653429f73334048a595790e897b53c4fe3a391e2f6389f427e3 +099a09722a46cbce09a2944b82f2addbb3341f986edbefe58277d8d9971a5e9b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.