From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Georgi Vlaev <joe@nucleusys.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: [PATCH] ASoC: cs42l52: Fix off-by-one boundary checking for cs42l52_get_clk()
Date: Sun, 16 Dec 2012 10:11:29 +0800 [thread overview]
Message-ID: <1355623889.9994.1.camel@phoenix> (raw)
The caller uses the return value of cs42l52_get_clk as array index,
the valid array index is 0 .. ARRAY_SIZE(clk_map_table) - 1.
Thus we need to ensure ret is less than ARRAY_SIZE(clk_map_table).
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/cs42l52.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
index 99bb1c6..66817f6 100644
--- a/sound/soc/codecs/cs42l52.c
+++ b/sound/soc/codecs/cs42l52.c
@@ -749,7 +749,7 @@ static int cs42l52_get_clk(int mclk, int rate)
}
}
}
- if (ret > ARRAY_SIZE(clk_map_table))
+ if (ret >= ARRAY_SIZE(clk_map_table))
return -EINVAL;
return ret;
}
--
1.7.9.5
next reply other threads:[~2012-12-16 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 2:11 Axel Lin [this message]
2012-12-16 14:10 ` [PATCH] ASoC: cs42l52: Fix off-by-one boundary checking for cs42l52_get_clk() Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355623889.9994.1.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=joe@nucleusys.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.