From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 6 of 6 v2] xen: sched_credit: add some
 tracing
Date: Mon, 17 Dec 2012 15:45:30 +0100
Message-ID: <1355755530.5931.18.camel@Abyss>
References: <patchbomb.1355280770@Solace>
	<036a3bb938a550f2ee0c.1355280776@Solace>
	<50CB8677.9050001@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2266619688742480579=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50CB8677.9050001@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Keir
	(Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============2266619688742480579==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-e+sNvWiBKjN8QlRlLvBh"

--=-e+sNvWiBKjN8QlRlLvBh
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2012-12-14 at 20:05 +0000, George Dunlap wrote:=20
> > -    /* Send scheduler interrupts to designated CPUs */
> >       if ( !cpumask_empty(&mask) )
> > +    {
> > +        if ( unlikely(tb_init_done) )
> > +        {
> > +            /* Avoid TRACE_*: saves checking !tb_init_done each step *=
/
> > +            for_each_cpu(cpu, &mask)
> > +                trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu);
> > +        }
>=20
> Hmm, probably should have pointed this out before, but trace_var() is a=
=20
> static inline which checks tb_init_done -- you want __trace_var(). :-)
>=20
Correct. My bad. It actually was __trace_var() at the beginning (that's
the reason why this particular record deserves special treatment), but I
messed things up while preparing this new version. Sorry for that and
thanks for having spotted this! :-)

Will fix.

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-e+sNvWiBKjN8QlRlLvBh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlDPMAoACgkQk4XaBE3IOsTjzQCbB+F9UkolfMD6Dj29xS2GQGPr
BM4An2wDqjZftv/nn5uzYL3/p08fh/B/
=iKfR
-----END PGP SIGNATURE-----

--=-e+sNvWiBKjN8QlRlLvBh--


--===============2266619688742480579==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2266619688742480579==--