From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Constantin Musca <constantinx.musca@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/7] udev: replace base_libdir with nonarch_base_libdir
Date: Mon, 17 Dec 2012 17:28:55 +0000 [thread overview]
Message-ID: <1355765335.32519.84.camel@ted> (raw)
In-Reply-To: <fc5ac72e09b464ee6eee1c1489de718238944b9a.1355732782.git.constantinx.musca@intel.com>
On Mon, 2012-12-17 at 11:16 +0200, Constantin Musca wrote:
> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
> ---
> meta/recipes-core/udev/udev.inc | 24 ++++++++++++------------
> meta/recipes-core/udev/udev_182.bb | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
> index 4705b9b..9f83821 100644
> --- a/meta/recipes-core/udev/udev.inc
> +++ b/meta/recipes-core/udev/udev.inc
> @@ -32,16 +32,16 @@ inherit autotools pkgconfig update-rc.d
>
> # udevd/udevadm -> /sbin/, libudev.so.* -> /lib/
> sbindir = "${base_sbindir}"
> -libexecdir = "${base_libdir}"
> +libexecdir = "${nonarch_base_libdir}"
> EXTRA_OECONF = "--disable-introspection \
> - --with-rootlibdir=${base_libdir} \
> + --with-rootlibdir=${nonarch_base_libdir} \
> --with-pci-ids-path=${datadir}/pci.ids \
> ac_cv_file__usr_share_pci_ids=no \
> ac_cv_file__usr_share_hwdata_pci_ids=no \
> ac_cv_file__usr_share_misc_pci_ids=yes \
> --sbindir=${base_sbindir} \
> - --libexecdir=${base_libdir} \
> - --with-rootlibdir=${base_libdir} \
> + --libexecdir=${nonarch_base_libdir} \
> + --with-rootlibdir=${nonarch_base_libdir} \
> --with-rootprefix= \
> "
>
> @@ -59,20 +59,20 @@ FILES_${PN} += "${libexecdir} ${libdir}/ConsoleKit"
> RRECOMMENDS_${PN} += "udev-utils"
>
> FILES_${PN}-dbg += "${libexecdir}/.debug"
> -FILES_${PN}-dbg += "${base_libdir}/udev/.debug/"
> -FILES_${PN}-dbg += "${base_libdir}/udev/.debug/*"
> +FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/"
> +FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/*"
> FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc"
> -FILES_libudev = "${base_libdir}/libudev.so.*"
> -FILES_libudev-dbg = "${base_libdir}/.debug/libudev.so.*"
> +FILES_libudev = "${nonarch_base_libdir}/libudev.so.*"
> +FILES_libudev-dbg = "${nonarch_base_libdir}/.debug/libudev.so.*"
> FILES_libudev-dev = "${includedir}/libudev.h ${libdir}/libudev.so ${libdir}/libudev.la \
> ${libdir}/libudev.a ${libdir}/pkgconfig/libudev.pc"
> -FILES_libgudev = "${base_libdir}/libgudev*.so.* ${libdir}/libgudev*.so.*"
> -FILES_libgudev-dbg = "${base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"
> +FILES_libgudev = "${nonarch_base_libdir}/libgudev*.so.* ${libdir}/libgudev*.so.*"
> +FILES_libgudev-dbg = "${nonarch_base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"
> FILES_libgudev-dev = "${includedir}/gudev* ${libdir}/libgudev*.so ${libdir}/libgudev*.la \
> ${libdir}/libgudev*.a ${libdir}/pkgconfig/gudev*.pc"
> FILES_udev-cache = "${sysconfdir}/init.d/udev-cache ${sysconfdir}/default/udev-cache"
>
> -FILES_udev-acl = "${base_libdir}/udev/udev-acl ${base_libdir}/udev/rules.d/70-acl.rules"
> +FILES_udev-acl = "${nonarch_base_libdir}/udev/udev-acl ${nonarch_base_libdir}/udev/rules.d/70-acl.rules"
This doesn't look right.
Binaries and libraries need to go into ${base_libdir}, rules and other
files that don't vary by architecture need to go into
${nonarch_base_libdir}.
Cheers,
Richard
next prev parent reply other threads:[~2012-12-17 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 9:16 [PATCH 0/7] udev and multilib changes Constantin Musca
2012-12-17 9:16 ` [PATCH 1/7] bitbake.conf: add nonarch_base_lib variable Constantin Musca
2012-12-17 9:16 ` [PATCH 2/7] udev: replace base_libdir with nonarch_base_libdir Constantin Musca
2012-12-17 17:28 ` Richard Purdie [this message]
2012-12-17 9:16 ` [PATCH 3/7] alsa-utils: Pass udev-rules-dir as parameter Constantin Musca
2012-12-17 9:16 ` [PATCH 4/7] pcmciautils: set correct udevdir and add missing debug files Constantin Musca
2012-12-17 9:16 ` [PATCH 5/7] bluez: set correct udevdir Constantin Musca
2012-12-17 9:16 ` [PATCH 6/7] polkit: fix multilib packaging issue Constantin Musca
2012-12-17 9:16 ` [PATCH 7/7] psplash: enable multilib Constantin Musca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355765335.32519.84.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=constantinx.musca@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.