From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: don't generate callback list entries for SPL
Date: Mon, 17 Dec 2012 12:53:27 -0600 [thread overview]
Message-ID: <1355770407.18495.2@snotra> (raw)
In-Reply-To: <20121217145259.GB6167@bill-the-cat> (from trini@ti.com on Mon Dec 17 08:52:59 2012)
On 12/17/2012 08:52:59 AM, Tom Rini wrote:
> On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote:
>
> > SPL doesn't use the environment. These list entries prevent the
> > functions from being garbage-collected, even though nothing will
> look at
> > the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to
> > break due to size limitations.
>
> SPL with networking support uses the environment, so you need to toss
> CONFIG_SPL_NET_SUPPORT into the test. That said, it's not an
> interactive environment and this might push that area over the size
> limit too (in the USB case, which is already pretty tight).
OK, I saw "env_*" stuff in the "ifndef CONFIG_SPL_BUILD" section, but
later some of it shows up in "ifdef CONFIG_SPL_BUILD" as well.
So, do you want a v2, or is it OK because it's not interactive? In the
latter case should env_callback.o be removed from the SPL build?
Also, env_nvedit.o, env_common.o, and env_flash.o are included for SPL
regardless of CONFIG_SPL_NET_SUPPORT. In fact it looks like
env_nvedit.o will be included twice if CONFIG_SPL_NET_SUPPORT is
enabled. :-P
-Scott
next prev parent reply other threads:[~2012-12-17 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 0:54 [U-Boot] [PATCH] env: don't generate callback list entries for SPL Scott Wood
2012-12-15 7:04 ` Joe Hershberger
2012-12-17 14:52 ` Tom Rini
2012-12-17 18:53 ` Scott Wood [this message]
2012-12-17 19:12 ` Tom Rini
2012-12-17 19:55 ` Wolfgang Denk
2012-12-17 19:58 ` Tom Rini
2012-12-17 20:11 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355770407.18495.2@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.