From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 1/4] nfsd: warn on odd reply state in nfsd_vfs_read
Date: Mon, 17 Dec 2012 23:45:50 -0500 [thread overview]
Message-ID: <1355805953-2473-2-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1355805953-2473-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
As far as I can tell this shouldn't currently happen--or if it does,
something is wrong and data is going to be corrupted.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/nfsd/vfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 0ef9b6b..b31e46e 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -936,6 +936,7 @@ nfsd_vfs_read(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
.u.data = rqstp,
};
+ WARN_ON_ONCE(rqstp->rq_resused != 1);
rqstp->rq_resused = 1;
host_err = splice_direct_to_actor(file, &sd, nfsd_direct_splice_actor);
} else {
--
1.7.9.5
next prev parent reply other threads:[~2012-12-18 4:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 4:45 nfsd patches J. Bruce Fields
2012-12-18 4:45 ` J. Bruce Fields [this message]
2012-12-18 4:45 ` [PATCH 2/4] nfsd4: cleanup: replace rq_resused count by rq_next_page pointer J. Bruce Fields
2012-12-18 4:45 ` [PATCH 3/4] nfsd4: free_stateid can use the current stateid J. Bruce Fields
2012-12-18 4:45 ` [PATCH 4/4] nfsd4: don't leave freed stateid hashed J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355805953-2473-2-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.