From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
To: Mark Zhang <nvmarkzhang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: dynamically calculate pll_d parameters
Date: Tue, 18 Dec 2012 10:19:36 +0100 [thread overview]
Message-ID: <1355822376.1490.55.camel@tellur> (raw)
In-Reply-To: <50D02B0F.4020307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Am Dienstag, den 18.12.2012, 16:36 +0800 schrieb Mark Zhang:
> I think we don't need to define a pll_ops for every individual pll.
> That'll be redundant. Just use one pll_ops(with parameter dynamically
> calculating) which is able to serve several plls is OK. Refer to
> tegra30_clocks_data.c, it has already implemented this.
>
This would be the right thing to do in the long run. But PLL_D requires
a lot less complexity than others to compute the PLL values, because of
the constraints that could be applied. That's why I started doing a
simple function to only make PLL_D dynamic.
I could certainly go ahead and come up with something which applies to
all PLLs, but I imagine this might be even a bigger validation hassle
for NVidia.
Also I'm still not sure how much this patch collides with the clock
rework. I don't know how far this rework has progressed already and I
would like to avoid doing redundant work. Prashant could you please
clarify?
Regards,
Lucas
next prev parent reply other threads:[~2012-12-18 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 17:58 [PATCH] ARM: tegra: dynamically calculate pll_d parameters Lucas Stach
[not found] ` <1355767103-5303-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2012-12-17 22:01 ` Stephen Warren
[not found] ` <50CF963E.7020506-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-17 22:16 ` Lucas Stach
2012-12-18 5:45 ` Prashant Gaikwad
2012-12-18 6:58 ` Thierry Reding
[not found] ` <20121218065857.GA5151-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-12-18 8:40 ` Lucas Stach
2012-12-18 8:36 ` Mark Zhang
[not found] ` <50D02B0F.4020307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-18 9:19 ` Lucas Stach [this message]
2012-12-18 16:40 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355822376.1490.55.camel@tellur \
--to=dev-8ppwabl0hbeelga04laivw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nvmarkzhang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.