From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 03 of 10 v2] xen: sched_credit: let the scheduler know about node-affinity Date: Thu, 20 Dec 2012 09:33:31 +0100 Message-ID: <1355992411.28419.25.camel@Abyss> References: <06d2f322a6319d8ba212.1355944039@Solace> <50D2B3DE.70206@ts.fujitsu.com> <1355991370.28419.15.camel@Abyss> <50D2CB96.4030509@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7148136116007305855==" Return-path: In-Reply-To: <50D2CB96.4030509@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , George Dunlap , Andrew Cooper , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Daniel De Graaf , Matt Wilson List-Id: xen-devel@lists.xenproject.org --===============7148136116007305855== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-soEKK+jj6u9847SlDWgB" --=-soEKK+jj6u9847SlDWgB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2012-12-20 at 08:25 +0000, Juergen Gross wrote:=20 > > BTW, can you be a little bit more specific about where you're suggestin= g > > to put it? I'm sorry but I'm not sure I figured what you mean by "the > > scheduler private per-pcpu area"... Do you perhaps mean making it a > > member of `struct csched_pcpu' ? >=20 > Yes, that's what I would suggest. >=20 Ok then, functionally, that is going to be exactly the same thing as where it is right now, i.e., a set of global per_cpu() variables. It is possible for your solution to bring some cache/locality benefits, although that will very much depends on single cases, architecture, workload, etc. That being said, I'm definitely fine with it and can go for it. It was Jan that suggested/asked to pull them out of the stack, and I guess it's George's taste that we value most when hacking sched_*.c, so let's see if they want to comment on this and then I'll decide. :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-soEKK+jj6u9847SlDWgB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlDSzVsACgkQk4XaBE3IOsRKHwCgpeiF6webHpgSFZx/8tYzlnBo N1kAn00yydD9voxHlT+/h2G/tWBPHlDD =WTHH -----END PGP SIGNATURE----- --=-soEKK+jj6u9847SlDWgB-- --===============7148136116007305855== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7148136116007305855==--