From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH 2/2] mac80211: properly stop/wake queues before/after off-channel
Date: Thu, 20 Dec 2012 14:46:37 +0100 [thread overview]
Message-ID: <1356011197.10029.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1356010879-10054-2-git-send-email-sgruszka@redhat.com> (sfid-20121220_144135_978357_0252CBD0)
On Thu, 2012-12-20 at 14:41 +0100, Stanislaw Gruszka wrote:
> if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
> - netif_tx_stop_all_queues(sdata->dev);
> + ieee80211_stop_queues_by_reason(&local->hw,
> + IEEE80211_QUEUE_STOP_REASON_OFFCHANNEL);
That won't work ... if you do this you can't send probe requests or
offchannel frames any more.
What we should be doing is refcount the netif queues as well to avoid
them starting because while offchannel the driver re-enables.
johannes
next prev parent reply other threads:[~2012-12-20 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 13:41 [PATCH 1/2] mac80211: synchronize scan off/on-channel and PS states Stanislaw Gruszka
2012-12-20 13:41 ` [PATCH 2/2] mac80211: properly stop/wake queues before/after off-channel Stanislaw Gruszka
2012-12-20 13:46 ` Johannes Berg [this message]
2013-01-14 16:49 ` [PATCH 1/2] mac80211: synchronize scan off/on-channel and PS states Seth Forshee
2013-01-16 14:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356011197.10029.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.