From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tom.zanussi@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id 932DAE0034C
	for <yocto@yoctoproject.org>; Thu, 20 Dec 2012 08:58:50 -0800 (PST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
	by fmsmga102.fm.intel.com with ESMTP; 20 Dec 2012 08:58:49 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.84,324,1355126400"; d="scan'208";a="267822690"
Received: from unknown (HELO [10.255.14.10]) ([10.255.14.10])
	by fmsmga002.fm.intel.com with ESMTP; 20 Dec 2012 08:58:48 -0800
Message-ID: <1356022728.30533.55.camel@empanada>
From: Tom Zanussi <tom.zanussi@intel.com>
To: Gary Thomas <gary@mlbassoc.com>
Date: Thu, 20 Dec 2012 10:58:48 -0600
In-Reply-To: <50D33CFE.2060108@mlbassoc.com>
References: <f339ca3f94ec7bb6a749c5973acb1f85bc1ace6c.1355766001.git.tom.zanussi@intel.com>
	<0c46e74f56afa3b2c2922209e8f746ca210c9152.1355766001.git.tom.zanussi@intel.com>
	<50D25E76.1000302@linux.intel.com> <1356020632.30533.51.camel@empanada>
	<50D33CFE.2060108@mlbassoc.com>
X-Mailer: Evolution 3.4.1 (3.4.1-2.fc17) 
Mime-Version: 1.0
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH 4/5] yocto-layer: add 'layer' template data
X-BeenThere: yocto@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Discussion of all things Yocto <yocto.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/yocto>,
	<mailto:yocto-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/yocto>
List-Post: <mailto:yocto@yoctoproject.org>
List-Help: <mailto:yocto-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/yocto>,
	<mailto:yocto-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2012 16:58:50 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Thu, 2012-12-20 at 09:29 -0700, Gary Thomas wrote:
> On 2012-12-20 09:23, Tom Zanussi wrote:
> > On Wed, 2012-12-19 at 16:40 -0800, Darren Hart wrote:
> >>
> >> On 12/17/2012 09:51 AM, tom.zanussi@intel.com wrote:
> >>> From: Tom Zanussi <tom.zanussi@intel.com>
> >>>
> >>> Add a 'layer' target containing all the data that will be used to
> >>> generate a generic yocto layer.
> >>>
> >>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> >>> ---
> >>
> >> Great stuff Tom, only one nit below:
> >>
> >>> new file mode 100644
> >>> index 0000000..90ce90e
> >>> --- /dev/null
> >>> +++ "b/scripts/lib/bsp/substrate/target/arch/layer/{{ if create_example_recipe == \"y\": }} recipes-example/example/{{=example_recipe_name}}-0.1/helloworld.c"	
> >>> @@ -0,0 +1,6 @@
> >>> +#include <stdio.h>
> >>> +
> >>> +int main(int argc, char **argv)
> >>> +{
> >>> +    printf("Hello World!\n");
> >>
> >> If you specify a return type of int, you should be returning one:
> >>
> >> 	return 0;
> >>
> >> :-)
> >>
> >
> > Hmm, I don't think that's actually necessary for main() - if you don't
> > specify a return value for main(), it should already implicitly return 0
> > IIRC...
> 
> Not true - that would be compiler specific and should not be relied on.
> Always best to be explicit (plus it will eliminate a GCC warning!)
> 

Yeah, true, and definitely can't hurt in any case.

Tom

> >
> > Tom
> >
> >>> +}
> >>
> >>
> >> Looks good otherwise.
>