From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 09 of 10 v2] xl: add node-affinity to the output of `xl list` Date: Fri, 21 Dec 2012 17:54:38 +0100 Message-ID: <1356108878.15403.87.camel@Abyss> References: <50D48F7D.5010001@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0630302041379138723==" Return-path: In-Reply-To: <50D48F7D.5010001@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , Andrew Cooper , Juergen Gross , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Daniel De Graaf , Matt Wilson List-Id: xen-devel@lists.xenproject.org --===============0630302041379138723== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-kCLvYiQeJBRRXsDPoSaY" --=-kCLvYiQeJBRRXsDPoSaY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-12-21 at 16:34 +0000, George Dunlap wrote:=20 > Just checking -- is the print_bitmap() thing pure code motion? If so,=20 > would you mind saying that explicitly in the commit message, just to=20 > save people time when reading this patch? >=20 It's _mostly_ code motion, but I had to hack it a tiny little bit to make it possible to use the same function for printing cpu and node bitmaps (basically, in case all bits are sets, the function was printing "any cpu" itself, which wasn't fitting well with node maps). But yeah, I should have mentioned what I just put here in the changelog. Will do in v3. > Other than that, looks OK to me -- I haven't done a detailed review of= =20 > the output layout however. >=20 That's the most tricky part of this patch! :-) For your and others convenience, here's how it looks like on my testbox (sorry for the extra long lines, but that's not my fault!): root@Zhaman:~# xl list Name ID Mem VCPUs State Time(s) Domain-0 0 375 16 r----- 2= 25.1 vm1 1 960 2 -b---- = 34.0 root@Zhaman:~# xl list -Z Name ID Mem VCPUs State Time(s) = Security Label Domain-0 0 375 16 r----- 2= 25.4 - vm1 1 960 2 -b---- = 34.0 - root@Zhaman:~# xl list -v Name ID Mem VCPUs State Time(s) = UUID Reason-Code Security Label Domain-0 0 375 16 r----- 2= 26.6 00000000-0000-0000-0000-000000000000 - - vm1 1 960 2 -b---- = 34.2 e36429cc-d2a2-4da7-b21d-b053f725e7a7 - - root@Zhaman:~# xl list -n Name ID Mem VCPUs State Time(s) NO= DE Affinity Domain-0 0 375 16 r----- 2= 26.8 any node vm1 1 960 2 -b---- = 34.2 0 root@Zhaman:~# xl list -nZ Name ID Mem VCPUs State Time(s) = Security Label NODE Affinity Domain-0 0 375 16 r----- 2= 26.9 - any node vm1 1 960 2 -b---- = 34.2 - 0 root@Zhaman:~# xl list -nv Name ID Mem VCPUs State Time(s) = UUID Reason-Code Security Label NODE Affinity Domain-0 0 375 16 r----- 2= 27.0 00000000-0000-0000-0000-000000000000 - - any nod= e vm1 1 960 2 -b---- = 34.2 e36429cc-d2a2-4da7-b21d-b053f725e7a7 - - 0 Reasonable enough? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-kCLvYiQeJBRRXsDPoSaY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlDUlE4ACgkQk4XaBE3IOsSy9gCfTqDOQiTXE83+LTkgTtsAAQ1d 9P4AnjWiV4M40zW+dKyNLxcRdEWuQFxv =mELr -----END PGP SIGNATURE----- --=-kCLvYiQeJBRRXsDPoSaY-- --===============0630302041379138723== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0630302041379138723==--