From: "he, bo" <bo.he@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
akpm@linux-foundation.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl
Cc: yanmin_zhang@linux.intel.com
Subject: [PATCH V2] output the cpu number when printking.
Date: Mon, 24 Dec 2012 13:01:55 +0800 [thread overview]
Message-ID: <1356325315.2385.74.camel@hebo> (raw)
In-Reply-To: <1356321255.2385.8.camel@hebo>
From: "he, bo" <bo.he@intel.com>
We often hit kernel panic issues on SMP machines because processes race
on multiple cpu. By adding a new parameter printk.cpu, kernel prints
cpu number at printk information line. It’s useful to debug what cpus
are racing.
Signed-off-by: he, bo <bo.he@intel.com>
---
Documentation/kernel-parameters.txt | 4 ++++
kernel/printk.c | 18 ++++++++++++++++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index ddd84d6..3387a7f 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -2378,6 +2378,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
printk.time= Show timing data prefixed to each printk message line
Format: <bool> (1/Y/y=enable, 0/N/n=disable)
+ printk.cpu= Show cpu data prefixed to each printk message line
+ Format: <bool> (1/Y/y=enable, 0/N/n=disable)
+ printk.cpu takes effect only when printk.time=y.
+
processor.max_cstate= [HW,ACPI]
Limit processor to maximum C-state
max_cstate=9 overrides any DMI blacklist limit.
diff --git a/kernel/printk.c b/kernel/printk.c
index 19c0d7b..873a226 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -863,9 +863,14 @@ static bool printk_time;
#endif
module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
+static bool printk_cpu = 1;
+module_param_named(cpu, printk_cpu, bool, S_IRUGO | S_IWUSR);
+
static size_t print_time(u64 ts, char *buf)
{
unsigned long rem_nsec;
+ size_t len = 0;
+ int this_cpu;
if (!printk_time)
return 0;
@@ -874,8 +879,17 @@ static size_t print_time(u64 ts, char *buf)
return 15;
rem_nsec = do_div(ts, 1000000000);
- return sprintf(buf, "[%5lu.%06lu] ",
- (unsigned long)ts, rem_nsec / 1000);
+
+ if (printk_cpu) {
+ this_cpu = raw_smp_processor_id();
+ len = sprintf(buf, "[%5lu.%06lu,%u] ",
+ (unsigned long)ts, rem_nsec / 1000, this_cpu);
+ } else {
+ len = sprintf(buf, "[%5lu.%06lu] ",
+ (unsigned long)ts, rem_nsec / 1000);
+ }
+
+ return len;
}
static size_t print_prefix(const struct log *msg, bool syslog, char *buf)
--
1.7.6
next prev parent reply other threads:[~2012-12-24 5:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 2:31 [PATCH] output the cpu number when printking he, bo
2012-12-24 3:37 ` Randy Dunlap
2012-12-24 3:54 ` he, bo
2012-12-24 5:01 ` he, bo [this message]
2012-12-24 17:55 ` [PATCH V2] " Greg KH
2012-12-25 1:09 ` Yanmin Zhang
2012-12-26 17:50 ` Greg KH
2012-12-27 6:49 ` He, Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356325315.2385.74.camel@hebo \
--to=bo.he@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.