From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Robert Love <robert.w.love@intel.com>,
devel@open-fcoe.org, James Smart <james.smart@emulex.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org
Subject: [PATCH -v2 16/26] scsi: rename random32() to prandom_u32()
Date: Thu, 3 Jan 2013 21:19:12 +0900 [thread overview]
Message-ID: <1357215562-6288-17-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1357215562-6288-1-git-send-email-akinobu.mita@gmail.com>
Use more preferable function name which implies using a pseudo-random
number generator.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Robert Love <robert.w.love@intel.com>
Cc: devel@open-fcoe.org
Cc: James Smart <james.smart@emulex.com>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: linux-driver@qlogic.com
Cc: linux-scsi@vger.kernel.org
---
No change from v1
drivers/scsi/fcoe/fcoe_ctlr.c | 4 ++--
drivers/scsi/lpfc/lpfc_hbadisc.c | 6 +++---
drivers/scsi/qla2xxx/qla_attr.c | 7 +++++--
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index 4a909d7..d870ccc 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -2153,7 +2153,7 @@ static void fcoe_ctlr_vn_restart(struct fcoe_ctlr *fip)
if (fip->probe_tries < FIP_VN_RLIM_COUNT) {
fip->probe_tries++;
- wait = random32() % FIP_VN_PROBE_WAIT;
+ wait = prandom_u32() % FIP_VN_PROBE_WAIT;
} else
wait = FIP_VN_RLIM_INT;
mod_timer(&fip->timer, jiffies + msecs_to_jiffies(wait));
@@ -2786,7 +2786,7 @@ static void fcoe_ctlr_vn_timeout(struct fcoe_ctlr *fip)
fcoe_all_vn2vn, 0);
fip->port_ka_time = jiffies +
msecs_to_jiffies(FIP_VN_BEACON_INT +
- (random32() % FIP_VN_BEACON_FUZZ));
+ (prandom_u32() % FIP_VN_BEACON_FUZZ));
}
if (time_before(fip->port_ka_time, next_time))
next_time = fip->port_ka_time;
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index d7096ad..bfda184 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -1732,7 +1732,7 @@ lpfc_check_pending_fcoe_event(struct lpfc_hba *phba, uint8_t unreg_fcf)
* use through a sequence of @fcf_cnt eligible FCF records with equal
* probability. To perform integer manunipulation of random numbers with
* size unit32_t, the lower 16 bits of the 32-bit random number returned
- * from random32() are taken as the random random number generated.
+ * from prandom_u32() are taken as the random random number generated.
*
* Returns true when outcome is for the newly read FCF record should be
* chosen; otherwise, return false when outcome is for keeping the previously
@@ -1744,7 +1744,7 @@ lpfc_sli4_new_fcf_random_select(struct lpfc_hba *phba, uint32_t fcf_cnt)
uint32_t rand_num;
/* Get 16-bit uniform random number */
- rand_num = (0xFFFF & random32());
+ rand_num = 0xFFFF & prandom_u32();
/* Decision with probability 1/fcf_cnt */
if ((fcf_cnt * rand_num) < 0xFFFF)
@@ -2380,7 +2380,7 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
phba->fcf.eligible_fcf_cnt = 1;
/* Seeding the random number generator for random selection */
seed = (uint32_t)(0xFFFFFFFF & jiffies);
- srandom32(seed);
+ prandom_seed(seed);
}
spin_unlock_irq(&phba->hbalock);
goto read_next_fcf;
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 83d7984..3658e9f 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -1933,8 +1933,11 @@ qla24xx_vport_delete(struct fc_vport *fc_vport)
/* No pending activities shall be there on the vha now */
if (ql2xextended_error_logging & ql_dbg_user)
- msleep(random32()%10); /* Just to see if something falls on
- * the net we have placed below */
+ msleep(prandom_u32() % 10);
+ /*
+ * Just to see if something falls on the net we have placed
+ * below
+ */
BUG_ON(atomic_read(&vha->vref_count));
--
1.7.11.7
next prev parent reply other threads:[~2013-01-03 12:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 12:18 [PATCH -v2 00/26] rename random32 to prandom Akinobu Mita
2013-01-03 12:18 ` [PATCH -v2 01/26] raid6test: use prandom_bytes() Akinobu Mita
2013-01-03 12:18 ` [PATCH -v2 02/26] uuid: " Akinobu Mita
2013-01-03 12:18 ` [PATCH -v2 03/26] x86: pageattr-test: remove srandom32 call Akinobu Mita
2013-01-03 17:35 ` H. Peter Anvin
2013-01-04 13:48 ` Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 04/26] x86: rename random32() to prandom_u32() Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 05/26] lib/: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 06/26] mm/: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 07/26] kernel/: " Akinobu Mita
2013-01-03 12:19 ` [Drbd-dev] [PATCH -v2 08/26] drbd: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
[not found] ` <1357215562-6288-1-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-03 12:19 ` [PATCH -v2 09/26] infiniband: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
[not found] ` <1357215562-6288-10-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-03 16:27 ` Steve Wise
2013-01-03 16:27 ` Steve Wise
2013-01-04 13:45 ` Akinobu Mita
[not found] ` <CAC5umygnMMC2sH2c88P_gEWTgwM=CBCUcqBbo+NX=fOZ2rEGxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-04 17:15 ` Steve Wise
2013-01-04 17:15 ` Steve Wise
2013-01-05 13:37 ` Akinobu Mita
2013-01-05 23:33 ` Steve Wise
2013-01-05 23:35 ` Steve Wise
2013-01-05 23:35 ` Steve Wise
2013-01-03 12:19 ` [PATCH -v2 10/26] mmc: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 11/26] video/uvesafb: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 12/26] xfs: " Akinobu Mita
2013-01-04 18:07 ` Ben Myers
2013-01-03 12:19 ` [PATCH -v2 13/26] ubifs: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
2013-01-15 13:47 ` Artem Bityutskiy
2013-01-15 13:47 ` Artem Bityutskiy
2013-01-03 12:19 ` [PATCH -v2 14/26] uwb: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 15/26] lguest: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita [this message]
2013-01-03 12:19 ` [PATCH -v2 17/26] mtd: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
2013-01-15 13:47 ` Artem Bityutskiy
2013-01-15 13:47 ` Artem Bityutskiy
2013-01-03 12:19 ` [PATCH -v2 18/26] drivers/net: " Akinobu Mita
2013-01-03 19:36 ` Bing Zhao
2013-01-03 12:19 ` [B.A.T.M.A.N.] [PATCH -v2 19/26] batman-adv: " Akinobu Mita
2013-01-03 12:19 ` Akinobu Mita
2013-01-04 2:12 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-01-04 2:12 ` Antonio Quartulli
2013-01-04 13:50 ` [B.A.T.M.A.N.] " Akinobu Mita
2013-01-04 13:50 ` Akinobu Mita
2013-01-06 9:00 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-01-06 9:00 ` Antonio Quartulli
2013-01-03 12:19 ` [PATCH -v2 20/26] net/sunrpc: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 21/26] net/sched: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 22/26] net/netfilter: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 23/26] net/core: " Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 24/26] net/core: remove duplicate statements by do-while loop Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 25/26] net: rename random32 to prandom Akinobu Mita
2013-01-03 12:19 ` [PATCH -v2 26/26] remove unused random32() and srandom32() Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357215562-6288-17-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.vasquez@qlogic.com \
--cc=devel@open-fcoe.org \
--cc=james.smart@emulex.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.