Re: [PATCH] latencytop: add sudo as runtime dependency

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2013-01-04 at 12:30 +0100, Maxin B. John wrote:
> From: "Maxin B. John" <maxin.john@enea.com>
> 
> Latencytop needs superuser privileges. The latencytop plugin in
> eclipse invokes it as 'sudo latencytop'. So, it will be good to
> include sudo as a runtime dependency.
> 
> Signed-off-by: Maxin B. John <maxin.john@enea.com>
> ---
>  meta/recipes-kernel/latencytop/latencytop_0.5.bb |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-kernel/latencytop/latencytop_0.5.bb b/meta/recipes-kernel/latencytop/latencytop_0.5.bb
> index 3e35bf9..a148a47 100644
> --- a/meta/recipes-kernel/latencytop/latencytop_0.5.bb
> +++ b/meta/recipes-kernel/latencytop/latencytop_0.5.bb
> @@ -7,6 +7,9 @@ LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a
>  
>  DEPENDS = "virtual/libintl ncurses glib-2.0  ${@base_contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}"
>  
> +# latencytop and it's eclipse support need sudo
> +RDEPENDS_${PN} = "sudo"
> +
>  PR = "r3"

Shouldn't the eclipse support RDEPEND on sudo, not latencytop? There are
several ways you could run latencytop without sudo...

Following this logic, we'd add an RDEPENDS on sudo for every app that
could possibly need root privs.

Cheers,

Richard