From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1TrCcF-0002cU-NU
	for qemu-devel@nongnu.org; Fri, 04 Jan 2013 14:07:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1TrCcD-0001cP-4y
	for qemu-devel@nongnu.org; Fri, 04 Jan 2013 14:07:39 -0500
Date: Fri, 4 Jan 2013 13:07:24 -0600
From: Scott Wood <scottwood@freescale.com>
In-Reply-To: <03A8D1A7-BBDC-4D05-930D-D28FFEF2AB71@suse.de> (from
	agraf@suse.de on Fri Jan  4 12:54:51 2013)
Message-ID: <1357326444.666.11@snotra>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 01/04/2013 12:54:51 PM, Alexander Graf wrote:
>=20
> On 04.01.2013, at 19:50, Scott Wood wrote:
>=20
> > On 01/04/2013 04:24:59 AM, Alexander Graf wrote:
> >>         msi_supported =3D true;
> >>         list =3D list_be;
> >> diff --git a/target-ppc/Makefile.objs b/target-ppc/Makefile.objs
> >> index 237a0ed..6c11ef8 100644
> >> --- a/target-ppc/Makefile.objs
> >> +++ b/target-ppc/Makefile.objs
> >> @@ -9,4 +9,3 @@ obj-y +=3D mmu_helper.o
> >> obj-y +=3D timebase_helper.o
> >> obj-y +=3D misc_helper.o
> >> obj-y +=3D mem_helper.o
> >> -obj-y +=3D mpic_helper.o
> >> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> >> index e88ebe0..0db06d6 100644
> >> --- a/target-ppc/cpu.h
> >> +++ b/target-ppc/cpu.h
> >> @@ -1068,6 +1068,8 @@ struct CPUPPCState {
> >>     target_ulong ivpr_mask;
> >>     target_ulong hreset_vector;
> >>     hwaddr mpic_cpu_base;
> >> +    /* true when the external proxy facility mode is enabled */
> >> +    int mpic_proxy;
> >> #endif
> >
> > bool?
>=20
> IIRC we can't save/restore bools easily using savevm, and this one =20
> should be saved/restored.

I see bool handlers in savevm.c.  I'm not sure how a non-fixed-size =20
"int" is better.

BTW, docs/migration.txt says that savevm is the "legacy" approach.

-Scott=