From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/3] netpoll: add IPv6 support
Date: Tue, 08 Jan 2013 11:55:51 +0800 [thread overview]
Message-ID: <1357617351.3544.8.camel@cr0> (raw)
In-Reply-To: <20130107.194621.1068055780988116658.davem@davemloft.net>
On Mon, 2013-01-07 at 19:46 -0800, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Mon, 7 Jan 2013 15:17:13 +0800
>
> > v4: remove ndisc_parse_options(), ignore ICMP options there
> > make udp6_csum_init() inline so that we don't rely on IPV6=y
> > fix a conflict with Jiri's patchset
>
> Where did I say to inline this function?
>
> I said to put it into a seperate static library that gets
> linked into the kernel statically, regardless of whether
> IPV6 is 'm' or 'y'.
>
> I've said this _3_ times and I'm really starting to get
> frustrated with the fact that you can't seem to read what
> I write.
>
> What part of the "obj-y +=" rules in net/ipv6/Makefile
> are you unable to see?
I knew.
Our goal is to make it work for IPV6=m, so why inline is not a solution
while putting it into a static library is? udp6_csum_init() is not a big
function, so I see no reason why it can't be inlined.
And AFAIK, udp6_csum_init() can't fit into any of these obj-y files in
net/ipv6/.
Am I still missing anything?
Thanks.
next prev parent reply other threads:[~2013-01-08 3:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 7:17 [PATCH net-next v4 0/3] netpoll: add IPv6 support Cong Wang
2013-01-07 7:17 ` [PATCH net-next v4 1/3] netpoll: prepare for ipv6 Cong Wang
2013-01-07 7:17 ` [PATCH net-next v4 2/3] netpoll: add IPv6 support Cong Wang
2013-01-07 7:17 ` [PATCH net-next v4 3/3] netconsole: add IPv6 example in doc Cong Wang
2013-01-08 3:46 ` [PATCH net-next v4 0/3] netpoll: add IPv6 support David Miller
2013-01-08 3:55 ` Cong Wang [this message]
2013-01-08 4:54 ` David Miller
2013-01-08 5:15 ` Cong Wang
2013-01-08 4:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357617351.3544.8.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.