All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <Wei.Liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <liuw@liuw.name>,
	wei.liu2@citrix.com,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [RFC PATCH 3/3] Implement 3-level event channel routines.
Date: Tue, 8 Jan 2013 17:33:13 +0000	[thread overview]
Message-ID: <1357666393.2743.1.camel@iceland> (raw)
In-Reply-To: <50E57B1402000078000B2AED@nat28.tlf.novell.com>

On Thu, 2013-01-03 at 11:35 +0000, Jan Beulich wrote:
> >>> On 31.12.12 at 19:22, Wei Liu <wei.liu2@citrix.com> wrote:
> >
> > +static void __unmap_l2_sel(struct vcpu *v)
> > +{
> > +    unsigned long mfn;
> > +
> > +    if ( v->evtchn_pending_sel_l2 != 0 )
> > +    {
> > +        unmap_domain_page_global(v->evtchn_pending_sel_l2);
> > +        mfn = virt_to_mfn(v->evtchn_pending_sel_l2);
> 
> virt_to_mfn() is not valid on the output of
> map_domain_page{,_global}() (same further down). Yes, there is
> at least one example of this in the existing code, but that's wrong
> too, and is getting eliminated by the 16Tb patch series I'm in the
> process of putting together.
> 

So what's the correct way to do this? Do I need to wait for your patch
series?


Wei.

  reply	other threads:[~2013-01-08 17:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-31 18:22 Implement 3-level event channels in Xen Wei Liu
2012-12-31 18:22 ` [RFC PATCH 1/3] Add a field in struct domain to indicate evtchn level Wei Liu
2013-01-02 11:11   ` David Vrabel
2013-01-02 14:28     ` Wei Liu
2012-12-31 18:22 ` [RFC PATCH 2/3] Dynamically allocate domain->evtchn, also bump EVTCHNS_PER_BUCKET to 512 Wei Liu
2013-01-02 13:38   ` David Vrabel
2013-01-02 14:27     ` Wei Liu
2013-01-03 10:36       ` Jan Beulich
2013-01-03 11:33         ` Wei Liu
2013-01-03 11:39           ` Jan Beulich
2012-12-31 18:22 ` [RFC PATCH 3/3] Implement 3-level event channel routines Wei Liu
2013-01-02 14:08   ` David Vrabel
2013-01-02 16:45   ` Ian Campbell
2013-01-03 10:46     ` Jan Beulich
2013-01-03 11:35   ` Jan Beulich
2013-01-08 17:33     ` Wei Liu [this message]
2013-01-09  8:38       ` Jan Beulich
2013-01-09 10:56         ` Ian Campbell
2013-01-09 11:24           ` Jan Beulich
2013-01-09 11:31             ` Ian Campbell
2013-01-09 11:41               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357666393.2743.1.camel@iceland \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=liuw@liuw.name \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.