From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Iorga, Cristian" <cristian.iorga@intel.com>
Cc: "Felipe F. Tonello" <ftonello@cercacor.com>,
"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH] connman: fixed init script, so it can run with nfs
Date: Wed, 09 Jan 2013 13:03:49 +0000 [thread overview]
Message-ID: <1357736629.13022.55.camel@ted> (raw)
In-Reply-To: <969F26A8BAB325438E7EB80D3C3134FB161DBDFD@IRSMSX102.ger.corp.intel.com>
On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
> Hello Felipe,
>
> I have some questions regarding this patch:
>
> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
> 2. In what way is connman affecting nfs? In other words, what is the root cause?
> 3. Which version of connman are you using?
>
> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
I'd also add that:
a) Patches to this part of the tree need to go to the OE-Core mailing list
b) Unconditionally running the expression is inefficient, it should move
inside the if statement as it triggers a number of exec calls. This may
sound trivial but that all mount up.
Cheers,
Richard
next prev parent reply other threads:[~2013-01-09 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 0:37 [PATCH] connman: fixed init script, so it can run with nfs eu
2013-01-09 10:12 ` Iorga, Cristian
2013-01-09 13:03 ` Richard Purdie [this message]
2013-01-09 18:14 ` Felipe Ferreri Tonello
2013-01-10 19:23 ` Felipe Ferreri Tonello
2013-01-10 23:57 ` Richard Purdie
2013-01-11 1:17 ` Felipe Ferreri Tonello
2013-01-11 16:13 ` Richard Purdie
2013-01-09 18:15 ` Felipe Ferreri Tonello
2013-01-10 7:33 ` Iorga, Cristian
[not found] <1349809566-7013-1-git-send-email-ftonello@cercacor.com>
2012-10-10 16:24 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357736629.13022.55.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=cristian.iorga@intel.com \
--cc=ftonello@cercacor.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.