All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Ben Hutchings <ben@decadent.org.uk>,
	libertas-dev@lists.infradead.org,
	linux-bluetooth@vger.kernel.org,
	Gustavo Padovan <gustavo@padovan.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: sd8688 firmware location
Date: Wed, 09 Jan 2013 16:45:04 -0600	[thread overview]
Message-ID: <1357771504.12030.59.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1357689361-7969-1-git-send-email-lkundrak@v3.sk>

On Wed, 2013-01-09 at 00:56 +0100, Lubomir Rintel wrote:
> Hi!
> 
> btmrvl_sdio and libertas_sdio both use firmware files sd8688.bin and
> sd8688_helper.bin. In linux-firmware, they're present in libertas/ tree and
> (since 3d32a58b) libertas_sdio perfers loading it from there, while it is able
> to fallback to load it from linux-firmware root. btmrvl_sdio, on the other hand
> only looks in the root and ends up not being successful.
> 
> Obviously, there are two solutions to the problem -- either teach btmrvl_sdio
> to look into libertas/, or move the files in linux-firmware tree. I don't
> really have a strong preference, though it probably makes less sense to keep in
> in libertas/, since the bluetooth hardware is not really marketed as "Libertas."
> 
> I'm following up with patches to linux and linux-firmware and I'd be very
> thankful if you could pick one (not both of them).

So the BT part and the wifi part have different SDIO IDs; are they
actually connected separately to the SDIO bus?  Or is the chip only in
one mode at one time or something like that?  Is there a problem with
having both libertas and btmrvl loaded at the same time since they're
essentially the same chip?

I don't really mind moving stuff to mrvl/ out of libertas/ for these
devices, but I do want some backwards compat code in libertas for that.
Unless, of course, Marcel was talking about symlinks in the
linux-firmware git tree, which would be fine with me.  The important
point is that simply updating your linux-firmware package or install or
whatever *should not* result in a failed firmware load.

Dan

  parent reply	other threads:[~2013-01-09 22:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 23:56 sd8688 firmware location Lubomir Rintel
2013-01-08 23:56 ` [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place Lubomir Rintel
2013-01-09  2:28   ` Marcel Holtmann
2013-01-09  2:43     ` Bing Zhao
2013-01-09  2:43       ` Bing Zhao
2013-01-09  6:31       ` Lubomir Rintel
2013-01-09  6:35         ` Marcel Holtmann
2013-01-18  7:33           ` Lubomir Rintel
2013-01-21  1:12             ` Ben Hutchings
2013-01-27 11:21               ` Lubomir Rintel
2013-02-18  3:18                 ` Ben Hutchings
2013-01-18  7:37       ` [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in proper location Lubomir Rintel
2013-01-18  7:58         ` Marcel Holtmann
2013-01-19 19:01           ` Lubomir Rintel
2013-01-19 20:23             ` Marcel Holtmann
2013-01-08 23:57 ` [PATCH] Move sd8688*.bin images away from libertas tree Lubomir Rintel
2013-01-09 22:45 ` Dan Williams [this message]
2013-01-10  1:20   ` sd8688 firmware location Bing Zhao
2013-01-10  1:20     ` Bing Zhao
2013-01-18  7:39   ` [PATCH] libertas sdio: look for 8688 firmware in common location Lubomir Rintel
2013-01-21  1:13   ` sd8688 firmware location Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357771504.12030.59.camel@dcbw.foobar.com \
    --to=dcbw@redhat.com \
    --cc=ben@decadent.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.