From: Wei Shuai <cpuwolf@gmail.com>
To: gregkh@linuxfoundation.org, alexey.orishko@stericsson.com,
hans.petter.selasky@stericsson.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Wei Shuai <cpuwolf@gmail.com>
Subject: [PATCH] CDC_NCM adding support IFF_NOARP for buggy device
Date: Thu, 10 Jan 2013 21:59:28 +0800 [thread overview]
Message-ID: <1357826368-30543-1-git-send-email-cpuwolf@gmail.com> (raw)
Signed-off-by: Wei Shuai <cpuwolf@gmail.com>
---
drivers/net/usb/cdc_ncm.c | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 71b6e92..9903f79 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -545,6 +545,7 @@ EXPORT_SYMBOL_GPL(cdc_ncm_unbind);
static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
{
int ret;
+ struct usb_device *udev = interface_to_usbdev(intf);
/* The MBIM spec defines a NCM compatible default altsetting,
* which we may have matched:
@@ -572,6 +573,10 @@ static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
cdc_ncm_comm_intf_is_mbim(intf->cur_altsetting))
return -ENODEV;
#endif
+ /* this buggy device cannot do ARP */
+ if( (le16_to_cpu(udev->descriptor.idVendor) == 0xAAAA) ) {
+ dev->net->flags |= IFF_NOARP;
+ }
/* NCM data altsetting is always 1 */
ret = cdc_ncm_bind_common(dev, intf, 1);
@@ -1186,6 +1191,16 @@ static const struct usb_device_id cdc_devs[] = {
.driver_info = (unsigned long) &wwan_info,
},
+ /* buggy device cannot send ARP */
+ { .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_VENDOR,
+ .idVendor = 0xAAAA,
+ .bInterfaceClass = USB_CLASS_COMM,
+ .bInterfaceSubClass = USB_CDC_SUBCLASS_NCM,
+ .bInterfaceProtocol = USB_CDC_PROTO_NONE,
+ .driver_info = (unsigned long) &wwan_info,
+ },
+
/* Huawei NCM devices disguised as vendor specific */
{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, 0xff, 0x02, 0x16),
.driver_info = (unsigned long)&wwan_info,
--
1.7.6.5
next reply other threads:[~2013-01-10 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 13:59 Wei Shuai [this message]
2013-01-10 14:10 ` [PATCH] CDC_NCM adding support IFF_NOARP for buggy device Oliver Neukum
2013-01-10 17:18 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357826368-30543-1-git-send-email-cpuwolf@gmail.com \
--to=cpuwolf@gmail.com \
--cc=alexey.orishko@stericsson.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.petter.selasky@stericsson.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.