From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH v2 19/21] Convert add_files_to_cache to take struct pathspec
Date: Fri, 11 Jan 2013 18:21:13 +0700 [thread overview]
Message-ID: <1357903275-16804-20-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1357903275-16804-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/add.c | 8 +++++---
builtin/commit.c | 2 +-
cache.h | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/builtin/add.c b/builtin/add.c
index 0295cef..5d262eb 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -80,13 +80,15 @@ static void update_callback(struct diff_queue_struct *q,
}
}
-int add_files_to_cache(const char *prefix, const char **pathspec, int flags)
+int add_files_to_cache(const char *prefix,
+ const struct pathspec *pathspec, int flags)
{
struct update_callback_data data;
struct rev_info rev;
init_revisions(&rev, prefix);
setup_revisions(0, NULL, &rev, NULL);
- init_pathspec(&rev.prune_data, pathspec);
+ if (pathspec)
+ rev.prune_data = *pathspec;
rev.diffopt.output_format = DIFF_FORMAT_CALLBACK;
rev.diffopt.format_callback = update_callback;
data.flags = flags;
@@ -437,7 +439,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
plug_bulk_checkin();
- exit_status |= add_files_to_cache(prefix, pathspec.raw, flags);
+ exit_status |= add_files_to_cache(prefix, &pathspec, flags);
if (add_new_files)
exit_status |= add_files(&dir, flags);
diff --git a/builtin/commit.c b/builtin/commit.c
index 2fe6054..d79613d 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -329,7 +329,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix,
*/
if (all || (also && pathspec.nr)) {
fd = hold_locked_index(&index_lock, 1);
- add_files_to_cache(also ? prefix : NULL, pathspec.raw, 0);
+ add_files_to_cache(also ? prefix : NULL, &pathspec, 0);
refresh_cache_or_die(refresh_flags);
update_main_cache_tree(WRITE_TREE_SILENT);
if (write_cache(fd, active_cache, active_nr) ||
diff --git a/cache.h b/cache.h
index 32298ba..3e09a61 100644
--- a/cache.h
+++ b/cache.h
@@ -1228,7 +1228,7 @@ void packet_trace_identity(const char *prog);
* return 0 if success, 1 - if addition of a file failed and
* ADD_FILES_IGNORE_ERRORS was specified in flags
*/
-int add_files_to_cache(const char *prefix, const char **pathspec, int flags);
+int add_files_to_cache(const char *prefix, const struct pathspec *pathspec, int flags);
/* diff.c */
extern int diff_auto_refresh_index;
--
1.8.0.rc2.23.g1fb49df
next prev parent reply other threads:[~2013-01-11 11:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 11:20 [PATCH v2 00/21] nd/parse-pathspec reroll Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 01/21] pathspec: save the non-wildcard length part Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 02/21] Add parse_pathspec() that converts cmdline args to struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 03/21] Export parse_pathspec() and convert some get_pathspec() calls Nguyễn Thái Ngọc Duy
2013-01-11 17:56 ` Matt Kraai
2013-01-12 6:00 ` Duy Nguyen
2013-01-11 11:20 ` [PATCH v2 04/21] clean: convert to use parse_pathspec Nguyễn Thái Ngọc Duy
2013-01-11 11:20 ` [PATCH v2 05/21] commit: " Nguyễn Thái Ngọc Duy
2013-01-12 22:54 ` Martin von Zweigbergk
2013-01-11 11:21 ` [PATCH v2 06/21] status: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 07/21] rerere: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 08/21] checkout: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 09/21] rm: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 10/21] ls-files: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 11/21] archive: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 12/21] add: " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 13/21] Convert read_cache_preload() to take struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 14/21] Convert unmerge_cache " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 15/21] checkout: convert read_tree_some " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 16/21] Convert report_path_error " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 17/21] Convert refresh_index " Nguyễn Thái Ngọc Duy
2013-01-11 14:19 ` Nguyen Thai Ngoc Duy
2013-01-11 11:21 ` [PATCH v2 18/21] Convert {read,fill}_directory " Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` Nguyễn Thái Ngọc Duy [this message]
2013-01-11 11:21 ` [PATCH v2 20/21] Convert more init_pathspec() to parse_pathspec() Nguyễn Thái Ngọc Duy
2013-01-11 11:21 ` [PATCH v2 21/21] Rename field "raw" to "_raw" in struct pathspec Nguyễn Thái Ngọc Duy
2013-01-11 14:26 ` [PATCH v2 22/21] Convert the last use of match_pathspec() and remove it Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357903275-16804-20-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.