All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>,
	Alan Cox <alan@linux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Zhao Yakui <yakui.zhao@intel.com>, Rob Clark <rob@ti.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Cong Ding <dinggnu@gmail.com>
Subject: [PATCH] gpu: drm/gma500/mdfld_dsi_output.c: remove unnecessary null pointer check
Date: Tue, 15 Jan 2013 01:30:57 +0100	[thread overview]
Message-ID: <1358209863-16570-1-git-send-email-dinggnu@gmail.com> (raw)

the variable sender is dereferenced in line 95, so it is no reason to check
null again in line 99.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 drivers/gpu/drm/gma500/mdfld_dsi_output.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
index 2d4ab48..67e439a 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
@@ -96,11 +96,6 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	u32 gen_ctrl_val;
 
-	if (!sender) {
-		DRM_ERROR("No sender found\n");
-		return;
-	}
-
 	/* Set default display backlight value to 85% (0xd8)*/
 	mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
 				true);
-- 
1.7.10.4

                 reply	other threads:[~2013-01-15  0:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358209863-16570-1-git-send-email-dinggnu@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alan@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@ti.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.