From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>
Subject: Re: [PATCH v3] dw_dmac: don't exceed AHB master number in dwc_get_data_width
Date: Wed, 16 Jan 2013 17:02:35 +0200 [thread overview]
Message-ID: <1358348555.12502.27.camel@smile> (raw)
In-Reply-To: <CAOh2x=nChhB3Bo7CnEZm_86OPBootPd5CqRZ8LCgS5RC4KhMWg@mail.gmail.com>
On Wed, 2013-01-16 at 19:37 +0530, Viresh Kumar wrote:
> On Wed, Jan 16, 2013 at 7:18 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > +static inline unsigned int dwc_get_master(struct dma_chan *chan, int master)
> > +{
> > + struct dw_dma *dw = to_dw_dma(chan->device);
> > + struct dw_dma_slave *dws = chan->private;
> > + unsigned int m = 0;
>
> :(
There a protection of wrong master parameter.
In the code I did
if ()
m = ...
else if ()
m = ...
Otherwise it would be 0.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-01-16 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 13:48 [PATCH v2] dw_dmac: allocate dma descriptors from DMA_COHERENT memory Andy Shevchenko
2013-01-16 13:48 ` [PATCH v3] dw_dmac: don't exceed AHB master number in dwc_get_data_width Andy Shevchenko
2013-01-16 14:07 ` Viresh Kumar
2013-01-16 15:02 ` Andy Shevchenko [this message]
2013-01-16 16:43 ` Viresh Kumar
2013-01-21 4:50 ` [PATCH v2] dw_dmac: allocate dma descriptors from DMA_COHERENT memory Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358348555.12502.27.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.