From: Cong Wang <amwang@redhat.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 1/2] xfrm: replace rwlock on xfrm_state_afinfo with rcu
Date: Thu, 17 Jan 2013 14:22:46 +0800 [thread overview]
Message-ID: <1358403766.3855.21.camel@cr0> (raw)
In-Reply-To: <50F6B1DC.4030307@linux-ipv6.org>
On Wed, 2013-01-16 at 22:57 +0900, YOSHIFUJI Hideaki wrote:
> Cong Wang wrote:
> >
> > static void xfrm_state_unlock_afinfo(struct xfrm_state_afinfo *afinfo)
> > - __releases(xfrm_state_afinfo_lock)
> > {
> > - write_unlock_bh(&xfrm_state_afinfo_lock);
> > + spin_unlock_bh(&xfrm_state_afinfo_lock);
> > }
> >
> > int xfrm_register_type(const struct xfrm_type *type, unsigned short family)
>
> Why removing __releases() hint?
There is no __acquires matched:
% git grep __acquires -- net/xfrm
<nothing output>
prev parent reply other threads:[~2013-01-17 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 8:05 [Patch net-next 1/2] xfrm: replace rwlock on xfrm_state_afinfo with rcu Cong Wang
2013-01-16 8:05 ` [Patch net-next 2/2] xfrm: replace rwlock on xfrm_km_list " Cong Wang
2013-01-17 8:34 ` [Patch net-next 3/2] xfrm: use separated locks to protect pointers of struct xfrm_state_afinfo Cong Wang
2013-01-18 8:54 ` Steffen Klassert
2013-01-16 13:57 ` [Patch net-next 1/2] xfrm: replace rwlock on xfrm_state_afinfo with rcu YOSHIFUJI Hideaki
2013-01-17 6:22 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358403766.3855.21.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.