From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Tyler Hall <tylerwhall@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] fetch2: Sort file checksums by value, not path
Date: Fri, 18 Jan 2013 12:45:22 +0000 [thread overview]
Message-ID: <1358513122.27799.21.camel@ted> (raw)
In-Reply-To: <1355959610-29470-1-git-send-email-tylerwhall@gmail.com>
On Wed, 2012-12-19 at 18:26 -0500, Tyler Hall wrote:
> Changing the path to a file could change the task hash even if the file
> still has the same checksum. This occurs when the task depends on
> multiple files and the sort order of their paths changes. Usually the
> sorting is consistent because layers tend to have the same relative
> paths, but this should take care of other configuations.
>
> The problem arose when using a .bbappend to add files to a recipe in
> another layer. If the layer is located alongside the other layers and
> their parent directory is moved, the hash does not change. However,
> moving the .bbappend layer outside of the common directory can change
> the path sort order and the task hash.
>
> Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
> ---
> lib/bb/fetch2/__init__.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Good catch, merged to master, thanks.
Richard
prev parent reply other threads:[~2013-01-18 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 23:26 [PATCH] fetch2: Sort file checksums by value, not path Tyler Hall
2013-01-18 12:45 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358513122.27799.21.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.