All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: "Hatice ERTÜRK" <haticeerturk27@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: else is not generally useful after a break or return
Date: Sat, 21 Feb 2015 22:34:31 +0100	[thread overview]
Message-ID: <13586314.AW5Wp0HSbj@wuerfel> (raw)
In-Reply-To: <1424542612-19551-1-git-send-email-haticeerturk27@gmail.com>

On Saturday 21 February 2015 20:16:52 Hatice ERTÜRK wrote:
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index bd79e9e..2b022be 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -1779,8 +1779,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
>                         plist = plist->next;
>                 else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
>                         return false;
> -               else
> -                       break;
> +
> +               break;
>         }
>  

This is not a correct change, you add a 'break' in the case that
the first condition was true, which did not exist earlier.

	Arnd


  reply	other threads:[~2015-02-21 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-21 18:16 [PATCH] Staging: rtl8188eu: core: else is not generally useful after a break or return Hatice ERTÜRK
2015-02-21 21:34 ` Arnd Bergmann [this message]
2015-02-21 21:47   ` [Outreachy kernel] " Hatice ERTÜRK
2015-02-21 21:56     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13586314.AW5Wp0HSbj@wuerfel \
    --to=arnd@arndb.de \
    --cc=haticeerturk27@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.