All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ashish Jangam <ashish.jangam@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
	<linux-kernel@vger.kernel.org>,
	David Dajun Chen <dchen@diasemi.com>
Subject: Re: [patch v1 2/5] regulator: da9055 change irq state to default
Date: Mon, 21 Jan 2013 14:05:12 +0530	[thread overview]
Message-ID: <1358757312.11746.11.camel@dhruva> (raw)
In-Reply-To: <C3AE124F08223B42BC95AEB82F0F6CED4313C7F1@KCHJEXMB03.kpit.com>

> -----Original Message-----
> > > > This patch changes the irq state from high to the now default low
> > > > state.
> 
> > > > This patch is dependent on the DA9055 MFD.
> 
> > > Why is this change required and why is there a dependency here?
> 
> > It has been decided to have nIRQ therefore the main mfd IRQ state needs
> 
> Won't this break all existing systems?
Since all of the existing users are using nIRQ therefore it was decided
to have the default state as nIRQ.
> 
> > to be changed. And since mfd children follows mfd irq state therefore
> > the dependency; though in case of mfd this may not affect.  
> 
> What makes you say that there is a dependency here?  It's really not at
> all obvious why a change to the primary IRQ signalling mechanism would
> affect the internal interrupts of the device.
Yes, functionally this dependency should not matter.However, if
mfd/primary irq state is low and its components are high then it shall
not look good. Therefore the term dependency was used, probably I should
have written it in a different manner.



       reply	other threads:[~2013-01-21  8:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <C3AE124F08223B42BC95AEB82F0F6CED4313C7F1@KCHJEXMB03.kpit.com>
2013-01-21  8:35 ` Ashish Jangam [this message]
2013-01-23 16:03   ` [patch v1 2/5] regulator: da9055 change irq state to default Mark Brown
2013-01-25  8:26     ` Ashish Jangam
     [not found] <C3AE124F08223B42BC95AEB82F0F6CED4313C79B@KCHJEXMB03.kpit.com>
2013-01-21  8:04 ` Ashish Jangam
2013-01-21  8:13   ` Mark Brown
2013-01-18  5:22 Ashish Jangam
2013-01-18  7:23 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358757312.11746.11.camel@dhruva \
    --to=ashish.jangam@kpitcummins.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dchen@diasemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.