From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Moll Date: Mon, 21 Jan 2013 15:19:58 +0000 Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set Message-Id: <1358781598.6590.4.camel@hornet> List-Id: References: <1356941588-25249-1-git-send-email-linux@roeck-us.net> <1356941588-25249-2-git-send-email-linux@roeck-us.net> In-Reply-To: <1356941588-25249-2-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: lm-sensors , Jean Delvare , "linux-kernel@vger.kernel.org" T24gTW9uLCAyMDEyLTEyLTMxIGF0IDA4OjEzICswMDAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOgo+ IEZpeDoKPiB2ZXhwcmVzcy5jOiBJbiBmdW5jdGlvbiDigJh2ZXhwcmVzc19od21vbl9uYW1lX3No b3figJk6Cj4gdmV4cHJlc3MuYzozNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2Yg ZnVuY3Rpb24KPiDigJhvZl9nZXRfcHJvcGVydHnigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rp b24tZGVjbGFyYXRpb25dCj4gdmV4cHJlc3MuYzozNDoyNzogd2FybmluZzogaW5pdGlhbGl6YXRp b24gbWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBi eSBkZWZhdWx0XQo+IHZleHByZXNzLmM6IEluIGZ1bmN0aW9uIOKAmHZleHByZXNzX2h3bW9uX2xh YmVsX3Nob3figJk6Cj4gdmV4cHJlc3MuYzo0MzoyMjogd2FybmluZzogaW5pdGlhbGl6YXRpb24g bWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIKPiB3aXRob3V0IGEgY2FzdCBbZW5hYmxlZCBieSBk ZWZhdWx0XQo+IAo+IFNlZW4gaWYgQ09ORklHX09GX0RFVklDRSBpcyBub3QgZGVmaW5lZC4gb2Zf Z2V0X3Byb3BlcnR5IGlzIGRlY2xhcmVkIGluCj4gb2YuaCB3aGljaCBpcyBvbmx5IGluY2x1ZGVk IGJ5IG9mX2RldmljZS5oIGlmIENPTkZJR19PRl9ERVZJQ0UgaXMgZGVmaW5lZC4KPiBvZi5oIG5l ZWRzIHRvIGJlIGluY2x1ZGVkIGRpcmVjdGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1ZW50ZXIg Um9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KClRoYW5rcywgR3VlbnRlciEgKG9mIGNvdXJzZSBp dCdzIHdheSB0b28gbGF0ZSBmb3IgQWNrZWQtYnk6IFBhd2VsIE1vbGwKPHBhd2VsLm1vbGxAYXJt LmNvbT4pCgpQYXdlbAoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9y ZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756157Ab3AUPUF (ORCPT ); Mon, 21 Jan 2013 10:20:05 -0500 Received: from service87.mimecast.com ([91.220.42.44]:44190 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335Ab3AUPUE convert rfc822-to-8bit (ORCPT ); Mon, 21 Jan 2013 10:20:04 -0500 Message-ID: <1358781598.6590.4.camel@hornet> Subject: Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set From: Pawel Moll To: Guenter Roeck Cc: lm-sensors , Jean Delvare , "linux-kernel@vger.kernel.org" Date: Mon, 21 Jan 2013 15:19:58 +0000 In-Reply-To: <1356941588-25249-2-git-send-email-linux@roeck-us.net> References: <1356941588-25249-1-git-send-email-linux@roeck-us.net> <1356941588-25249-2-git-send-email-linux@roeck-us.net> X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 X-OriginalArrivalTime: 21 Jan 2013 15:19:58.0446 (UTC) FILETIME=[C64570E0:01CDF7EA] X-MC-Unique: 113012115200203601 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-12-31 at 08:13 +0000, Guenter Roeck wrote: > Fix: > vexpress.c: In function ‘vexpress_hwmon_name_show’: > vexpress.c:34:2: error: implicit declaration of function > ‘of_get_property’ [-Werror=implicit-function-declaration] > vexpress.c:34:27: warning: initialization makes pointer from integer > without a cast [enabled by default] > vexpress.c: In function ‘vexpress_hwmon_label_show’: > vexpress.c:43:22: warning: initialization makes pointer from integer > without a cast [enabled by default] > > Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in > of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined. > of.h needs to be included directly. > > Signed-off-by: Guenter Roeck Thanks, Guenter! (of course it's way too late for Acked-by: Pawel Moll ) Pawel