All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: vexpress: export global functions to fix build error
Date: Mon, 21 Jan 2013 15:44:05 +0000	[thread overview]
Message-ID: <1358783045.6590.26.camel@hornet> (raw)
In-Reply-To: <1357463779-28096-1-git-send-email-linux@roeck-us.net>

On Sun, 2013-01-06 at 09:16 +0000, Guenter Roeck wrote:
> Compiling vexpress client drivers as module results in error messages such as
> 
> ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> 
> This is because the global functions in drivers/mfd/vexpress-config.c are not
> exported. Fix it.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Uh, right. Exported read/write but those are pretty much useless without
the other ones...

Thanks a lot, I'll get it queued with the other vexpress fixes and push
it upstream as soon as possible!

Pawel



  reply	other threads:[~2013-01-21 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-06  9:16 [PATCH] mfd: vexpress: export global functions to fix build error Guenter Roeck
2013-01-21 15:44 ` Pawel Moll [this message]
2013-01-22  3:30 ` Samuel Ortiz
2013-01-22 12:20   ` Guenter Roeck
2013-01-22 16:29     ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358783045.6590.26.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.