Re: RFC: bugfix for 3575

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2013-01-23 at 12:08 +0200, Marinescu, Bogdan A wrote:
> Please review my fix of bug 3575 (Ensure windows hob client
> communication with bitbake backend via xmlrpc). I'd like to get
> feedback before uploading the patches. I've pushed my fix on
> poky-contrib:
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bogdanm/b3575
>
> Currently, the fix allows bitbake and hob to run on different machines
> and "talk" to each other via XMLRPC (no windows version yet, but it
> can be tested in Linux). Hopefully the commit messages will tell the
> rest of the story.

First two commits are no problem.

Third Commit:

I don't like the merging of all the extra cache data. I think when a
given UI registers, it needs to call into cooker and inform bitbake it
requires the extra caches (if it does so). With your current code, we
might as well throw away the extra cache code as it effectively works as
the greatest set. I see this only happens in server mode but I'm still
not 100% convinced its the right thing to do.

I also don't see why knotty can't work in server mode?

Fourth Commit:

I have a strong opinion that we want to support multiple clients
connected to one server. I appreciate this complicates things and
currently would be chaotic. I think the easiest way to deal with this is
to have some notion of a single "controller" which would perhaps be
represented by the token. We'd then have some kind of handoff process so
that a given UI could claim the token and then control the server. We
might be able to lose the need for the manual reclaim option too if we
can tie this to the registered handlers somehow?

Any thoughts on that approach? 

Cheers,

Richard