All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S
Date: Fri, 25 Jan 2013 10:24:17 -0600	[thread overview]
Message-ID: <1359131057.32148.9.camel@linux-builds1> (raw)
In-Reply-To: <20130125154955.GD10055@amd.pavel.ucw.cz>

Hi Pavel,
On Fri, 2013-01-25 at 16:49 +0100, Pavel Machek wrote:
> Hi!
> 
> > mach-socfpga is another platform that needs to use
> > v7_invalidate_l1 to bringup additional cores. There was a comment that
> > the ideal place for v7_invalidate_l1 should be in arm/mm/cache-v7.S
> 
> If there are three copies of code, with fourth one needed for next
> platform, moving it into common code makes sense.
> 
> But... The code was not identical before the merge. Are you sure that
> the differences do not hurt? At the very least, it should be mentioned
> in the changelog.

Indeed, the addition of 

mcr     p15, 0, r0, c7, c5, 0   @ invalidate I cache

was done by commit # 5b2acf384c8a8707d32a98106192ee7187e4446d

This adds invalidate I-Cache as well as D-Cache, which I think should be
ok for most platforms. 

Hopefully, Stephen can test and verify.

Dinh
> 
> Thanks,
> 								Pavel
> 
> > diff --git a/arch/arm/mach-imx/headsmp.S b/arch/arm/mach-imx/headsmp.S
> > index 7e49deb..921fc15 100644
> > --- a/arch/arm/mach-imx/headsmp.S
> > +++ b/arch/arm/mach-imx/headsmp.S
> > @@ -17,53 +17,6 @@
> > -ENTRY(v7_invalidate_l1)
> > -	mov	r0, #0
> > -	mcr	p15, 0, r0, c7, c5, 0	@ invalidate I cache
> > -	mcr	p15, 2, r0, c0, c0, 0
> > -	mrc	p15, 1, r0, c0, c0, 0
> ...
> > diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S
> > index 4a317fa..fb082c4 100644
> > --- a/arch/arm/mach-tegra/headsmp.S
> > +++ b/arch/arm/mach-tegra/headsmp.S
> > @@ -18,49 +18,6 @@
> > -ENTRY(v7_invalidate_l1)
> > -        mov     r0, #0
> > -        mcr     p15, 2, r0, c0, c0, 0
> > -        mrc     p15, 1, r0, c0, c0, 0
> 
> [Note missing mcr p15, 0, .. line.]
> 
> 

  reply	other threads:[~2013-01-25 16:24 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  1:00 [PATCHv1 for soc 0/5] Enabling socfpga on hardware dinguyen at altera.com
2013-01-25  1:00 ` [PATCHv1 for soc 1/5] arm: socfpga: Add new device tree source for actual socfpga HW dinguyen at altera.com
2013-01-25 14:22   ` Pavel Machek
2013-01-25 16:18     ` Dinh Nguyen
2013-01-28  7:12   ` Olof Johansson
2013-01-25  1:00 ` [PATCHv1 for soc 2/5] arm: socfpga: Add clock entries to socfpga.dtsi dinguyen at altera.com
2013-01-28  7:13   ` Olof Johansson
2013-01-28 11:19     ` Pavel Machek
2013-01-25  1:00 ` [PATCHv1 for soc 3/5] arm: socfpga: Add entries to enable make dtbs socfpga dinguyen at altera.com
2013-01-25 15:13   ` Pavel Machek
2013-01-25 16:21     ` Dinh Nguyen
2013-01-25  1:00 ` [PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S dinguyen at altera.com
2013-01-25  4:15   ` Simon Horman
2013-01-25  4:35     ` Simon Horman
2013-01-25 16:18       ` Dinh Nguyen
2013-01-25  4:42   ` Stephen Warren
2013-01-28 10:45     ` Pavel Machek
2013-01-28 17:27       ` Stephen Warren
2013-01-28 17:35         ` Dinh Nguyen
2013-01-25  8:13   ` Santosh Shilimkar
2013-01-25 16:20     ` Dinh Nguyen
2013-01-25 17:47       ` Santosh Shilimkar
2013-01-25 15:49   ` Pavel Machek
2013-01-25 16:24     ` Dinh Nguyen [this message]
2013-01-25 18:05       ` Pavel Machek
2013-01-28 13:13       ` Shawn Guo
2013-01-25  1:00 ` [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware dinguyen at altera.com
2013-01-25 17:55   ` Pavel Machek
2013-01-25 21:02     ` Dinh Nguyen
2013-01-26 20:59       ` Pavel Machek
2013-01-28 19:31   ` Pavel Machek
2013-01-28 19:36   ` [RFC] socfpga: make function static Pavel Machek
2013-01-29 18:43   ` [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359131057.32148.9.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.