From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, fw@strlen.de, netdev@vger.kernel.org,
pablo@netfilter.org, amwang@redhat.com, kaber@trash.net,
dborkman@redhat.com
Subject: Re: [net-next PATCH 2/6] net: cacheline adjust struct inet_frags for better frag performance
Date: Tue, 29 Jan 2013 08:30:01 +0100 [thread overview]
Message-ID: <1359444601.7119.9.camel@localhost> (raw)
In-Reply-To: <20130128.232342.399301649354832893.davem@davemloft.net>
On Mon, 2013-01-28 at 23:23 -0500, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@redhat.com>
> Date: Thu, 24 Jan 2013 15:04:20 +0100
>
> > + /* --- read-mostly cacheline boundary (was 24 bytes ago) --- */
>
> This "24" is context dependent, I assume it applies to 64-bit builds
> rather than 32-bit ones.
True
> Either add the necessary details or just get rid of this part of the
> comment altogether.
I'll remove the comment altogether, and resubmit the patchset.
Thanks for your review. (Hope your flu is gone, and your backlog didn't
grow too big)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2013-01-29 7:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 14:04 [net-next PATCH 0/6] net: frag performance tuning cachelines for NUMA/SMP systems Jesper Dangaard Brouer
2013-01-24 14:04 ` [net-next PATCH 1/6] net: cacheline adjust struct netns_frags for better frag performance Jesper Dangaard Brouer
2013-01-24 14:04 ` [net-next PATCH 2/6] net: cacheline adjust struct inet_frags " Jesper Dangaard Brouer
2013-01-29 4:23 ` David Miller
2013-01-29 7:30 ` Jesper Dangaard Brouer [this message]
2013-01-24 14:04 ` [net-next PATCH 3/6] net: cacheline adjust struct inet_frag_queue Jesper Dangaard Brouer
2013-01-24 14:04 ` [net-next PATCH 4/6] net: frag helper functions for mem limit tracking Jesper Dangaard Brouer
2013-01-24 14:04 ` [net-next PATCH 5/6] net: use lib/percpu_counter API for fragmentation mem accounting Jesper Dangaard Brouer
2013-01-29 4:24 ` David Miller
2013-01-29 7:31 ` Jesper Dangaard Brouer
2013-01-24 14:05 ` [net-next PATCH 6/6] net: frag, move LRU list maintenance outside of rwlock Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359444601.7119.9.camel@localhost \
--to=brouer@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.