From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH 2/3] mac80211: generate mesh probe requests
Date: Mon, 04 Feb 2013 18:38:42 +0100 [thread overview]
Message-ID: <1359999522.17993.20.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1359853341-29237-3-git-send-email-thomas@cozybit.com> (sfid-20130203_020332_915907_BE35B422)
On Sat, 2013-02-02 at 17:02 -0800, Thomas Pedersen wrote:
> - pos = skb_put(skb, ie_ssid_len);
> - *pos++ = WLAN_EID_SSID;
> + if (ieee80211_vif_is_mesh(vif)) {
> + pos = skb_put(skb, 2 + 2 + ssid_len);
> + *pos++ = WLAN_EID_SSID;
> + *pos++ = 0;
> + /* NOTE: mesh ID will be out of order */
Why put it out of order?
Also I'm not convinced that it's a good idea to translate "SSID" from
the userspace API to "mesh ID" silently? Might make more sense to have
those separately maybe? I mean, it seems reasonable to even think you
might scan for a mesh network when you're not a mesh interface, for
example?
johannes
next prev parent reply other threads:[~2013-02-04 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 1:02 [PATCH 0/3] implement active mesh scanning Thomas Pedersen
2013-02-03 1:02 ` [PATCH 1/3] mac80211: cache mesh beacon Thomas Pedersen
2013-02-04 17:37 ` Johannes Berg
2013-02-04 18:09 ` Thomas Pedersen
2013-02-04 18:13 ` Johannes Berg
2013-02-03 1:02 ` [PATCH 2/3] mac80211: generate mesh probe requests Thomas Pedersen
2013-02-04 17:38 ` Johannes Berg [this message]
2013-02-04 17:57 ` Thomas Pedersen
2013-02-04 17:58 ` Thomas Pedersen
2013-02-04 18:03 ` Johannes Berg
2013-02-04 18:16 ` Thomas Pedersen
2013-02-03 1:02 ` [PATCH 3/3] mac80211: generate mesh probe responses Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359999522.17993.20.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.