All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon@janc.net.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] hostname: Fallback to static hostname if pretty hostname is not set
Date: Wed, 06 Feb 2013 09:44:08 +0200	[thread overview]
Message-ID: <1360136648.15783.3.camel@aeonflux> (raw)
In-Reply-To: <1360098656-12488-1-git-send-email-szymon@janc.net.pl>

Hi Szymon,

> If pretty hostname is not set fallback to static hostname (if it is
> set). If static or pretty hostname is not set appropriate properties
> are empty strings not NULLs. This behaviour is recomended by hostnamed.
> 
> Also fix setting adapter name to empty string if pretty hostname was
> not set.

please do not squeeze to patches into one.

I am also not convinced that we should bother with the static hostname
at all. I left this out on purpose. My thinking here was that if we do
not have a pretty hostname, then why bother with trying to make
something useful out of the hostname, it would be ugly or wrong anyway.

Regards

Marcel



  parent reply	other threads:[~2013-02-06  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 21:10 [PATCH 1/2] hostname: Fallback to static hostname if pretty hostname is not set Szymon Janc
2013-02-05 21:10 ` [PATCH 2/2] adapter: Set default adapter id sooner Szymon Janc
2013-02-06  7:57   ` Marcel Holtmann
2013-02-06 19:54     ` Szymon Janc
2013-02-06  7:44 ` Marcel Holtmann [this message]
2013-02-06 20:29   ` [PATCH 1/2] hostname: Fallback to static hostname if pretty hostname is not set Szymon Janc
2013-02-07  8:31     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360136648.15783.3.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon@janc.net.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.