From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1360173353.22154.4.camel@debian> From: Emil Goode Date: Wed, 06 Feb 2013 18:55:53 +0100 In-Reply-To: <20130206172234.GB6008@ritirata.org> References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> Content-Type: text/plain; charset="utf-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antonio Quartulli Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, siwu@hrz.tu-chemnitz.de, lindner_marek@yahoo.de, davem@davemloft.net Hi Antonio, The commit ed242d01 is in the linux-next tree and my patch depends on that commit. Best regards, Emil On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > The commit ed242d01 removed a node parameter from iterators. > > This patch removes a hlist_node struct that is no longer used. > > > > Sparse gives a warning: > > > > net/batman-adv/originator.c:411:21: warning: > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > Signed-off-by: Emil Goode > > On which tree did you base your patch? > I cannot find the commit you are referring to (ed242d01) and the patch does not > apply (neither on net nor net-next). > > Other than that the variable is used a couple of lines below (in the code we > have)... > > Regards, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Goode Date: Wed, 06 Feb 2013 17:55:53 +0000 Subject: Re: [PATCH] batman-adv: Remove unused variable Message-Id: <1360173353.22154.4.camel@debian> List-Id: References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> In-Reply-To: <20130206172234.GB6008@ritirata.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de, davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hi Antonio, The commit ed242d01 is in the linux-next tree and my patch depends on that commit. Best regards, Emil On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > The commit ed242d01 removed a node parameter from iterators. > > This patch removes a hlist_node struct that is no longer used. > > > > Sparse gives a warning: > > > > net/batman-adv/originator.c:411:21: warning: > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > Signed-off-by: Emil Goode > > On which tree did you base your patch? > I cannot find the commit you are referring to (ed242d01) and the patch does not > apply (neither on net nor net-next). > > Other than that the variable is used a couple of lines below (in the code we > have)... > > Regards, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757701Ab3BFRxv (ORCPT ); Wed, 6 Feb 2013 12:53:51 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:39575 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296Ab3BFRxt (ORCPT ); Wed, 6 Feb 2013 12:53:49 -0500 Message-ID: <1360173353.22154.4.camel@debian> Subject: Re: [PATCH] batman-adv: Remove unused variable From: Emil Goode To: Antonio Quartulli Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de, davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Wed, 06 Feb 2013 18:55:53 +0100 In-Reply-To: <20130206172234.GB6008@ritirata.org> References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antonio, The commit ed242d01 is in the linux-next tree and my patch depends on that commit. Best regards, Emil On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > The commit ed242d01 removed a node parameter from iterators. > > This patch removes a hlist_node struct that is no longer used. > > > > Sparse gives a warning: > > > > net/batman-adv/originator.c:411:21: warning: > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > Signed-off-by: Emil Goode > > On which tree did you base your patch? > I cannot find the commit you are referring to (ed242d01) and the patch does not > apply (neither on net nor net-next). > > Other than that the variable is used a couple of lines below (in the code we > have)... > > Regards, >