From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1360187945.25903.5.camel@debian> From: Emil Goode Date: Wed, 06 Feb 2013 22:59:05 +0100 In-Reply-To: <20130206195557.GC6008@ritirata.org> References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> <1360173353.22154.4.camel@debian> <20130206195557.GC6008@ritirata.org> Content-Type: text/plain; charset="utf-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antonio Quartulli Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, siwu@hrz.tu-chemnitz.de, lindner_marek@yahoo.de, davem@davemloft.net Hi Antonio, If it is easier I can keep an eye on when the commit lands in the net-next tree and then resend a modified version of the patch. Or do you want me to resend it now? Best regards, Emil On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote: > > Hi Antonio, > > > > The commit ed242d01 is in the linux-next tree and my patch depends on > > that commit. > > > > Yes, you are right. I was not aware of this commit, because the author > did not CC us (neither netdev) even if he changed the code we maintain. > > As far as I can see that commit is in linux-next only. > Therefore it must be applied there. > > However, I'd like you to change the commit message and write the full hash of > the commit you are referring to and its subject ("LIKE THIS"). This would make > it easier to find it. > > > Regards, > > > Best regards, Emil > > > > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > > > Hi Emil, > > > > > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > > > The commit ed242d01 removed a node parameter from iterators. > > > > This patch removes a hlist_node struct that is no longer used. > > > > > > > > Sparse gives a warning: > > > > > > > > net/batman-adv/originator.c:411:21: warning: > > > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > > > > > Signed-off-by: Emil Goode > > > > > > On which tree did you base your patch? > > > I cannot find the commit you are referring to (ed242d01) and the patch does not > > > apply (neither on net nor net-next). > > > > > > Other than that the variable is used a couple of lines below (in the code we > > > have)... > > > > > > Regards, > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Goode Date: Wed, 06 Feb 2013 21:59:05 +0000 Subject: Re: [PATCH] batman-adv: Remove unused variable Message-Id: <1360187945.25903.5.camel@debian> List-Id: References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> <1360173353.22154.4.camel@debian> <20130206195557.GC6008@ritirata.org> In-Reply-To: <20130206195557.GC6008@ritirata.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Antonio Quartulli Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de, davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hi Antonio, If it is easier I can keep an eye on when the commit lands in the net-next tree and then resend a modified version of the patch. Or do you want me to resend it now? Best regards, Emil On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote: > > Hi Antonio, > > > > The commit ed242d01 is in the linux-next tree and my patch depends on > > that commit. > > > > Yes, you are right. I was not aware of this commit, because the author > did not CC us (neither netdev) even if he changed the code we maintain. > > As far as I can see that commit is in linux-next only. > Therefore it must be applied there. > > However, I'd like you to change the commit message and write the full hash of > the commit you are referring to and its subject ("LIKE THIS"). This would make > it easier to find it. > > > Regards, > > > Best regards, Emil > > > > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > > > Hi Emil, > > > > > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > > > The commit ed242d01 removed a node parameter from iterators. > > > > This patch removes a hlist_node struct that is no longer used. > > > > > > > > Sparse gives a warning: > > > > > > > > net/batman-adv/originator.c:411:21: warning: > > > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > > > > > Signed-off-by: Emil Goode > > > > > > On which tree did you base your patch? > > > I cannot find the commit you are referring to (ed242d01) and the patch does not > > > apply (neither on net nor net-next). > > > > > > Other than that the variable is used a couple of lines below (in the code we > > > have)... > > > > > > Regards, > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758649Ab3BFV4x (ORCPT ); Wed, 6 Feb 2013 16:56:53 -0500 Received: from mail-la0-f51.google.com ([209.85.215.51]:57652 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758502Ab3BFV4s (ORCPT ); Wed, 6 Feb 2013 16:56:48 -0500 Message-ID: <1360187945.25903.5.camel@debian> Subject: Re: [PATCH] batman-adv: Remove unused variable From: Emil Goode To: Antonio Quartulli Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de, davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Wed, 06 Feb 2013 22:59:05 +0100 In-Reply-To: <20130206195557.GC6008@ritirata.org> References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> <1360173353.22154.4.camel@debian> <20130206195557.GC6008@ritirata.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Antonio, If it is easier I can keep an eye on when the commit lands in the net-next tree and then resend a modified version of the patch. Or do you want me to resend it now? Best regards, Emil On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote: > Hi Emil, > > On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote: > > Hi Antonio, > > > > The commit ed242d01 is in the linux-next tree and my patch depends on > > that commit. > > > > Yes, you are right. I was not aware of this commit, because the author > did not CC us (neither netdev) even if he changed the code we maintain. > > As far as I can see that commit is in linux-next only. > Therefore it must be applied there. > > However, I'd like you to change the commit message and write the full hash of > the commit you are referring to and its subject ("LIKE THIS"). This would make > it easier to find it. > > > Regards, > > > Best regards, Emil > > > > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > > > Hi Emil, > > > > > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > > > The commit ed242d01 removed a node parameter from iterators. > > > > This patch removes a hlist_node struct that is no longer used. > > > > > > > > Sparse gives a warning: > > > > > > > > net/batman-adv/originator.c:411:21: warning: > > > > unused variable ‘node_tmp’ [-Wunused-variable] > > > > > > > > Signed-off-by: Emil Goode > > > > > > On which tree did you base your patch? > > > I cannot find the commit you are referring to (ed242d01) and the patch does not > > > apply (neither on net nor net-next). > > > > > > Other than that the variable is used a couple of lines below (in the code we > > > have)... > > > > > > Regards, > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Goode Subject: Re: [PATCH] batman-adv: Remove unused variable Date: Wed, 06 Feb 2013 22:59:05 +0100 Message-ID: <1360187945.25903.5.camel@debian> References: <1360168661-16871-1-git-send-email-emilgoode@gmail.com> <20130206172234.GB6008@ritirata.org> <1360173353.22154.4.camel@debian> <20130206195557.GC6008@ritirata.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, siwu-MaAgPAbsBIVS8oHt8HbXEIQuADTiUCJX@public.gmane.org, lindner_marek-LWAfsSFWpa4@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Antonio Quartulli Return-path: In-Reply-To: <20130206195557.GC6008-E/2OGukznS5g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org Hi Antonio, If it is easier I can keep an eye on when the commit lands in the net-next tree and then resend a modified version of the patch. Or do you want me to resend it now? Best regards, Emil On Wed, 2013-02-06 at 20:55 +0100, Antonio Quartulli wrote: > Hi Emil, >=20 > On Wed, Feb 06, 2013 at 06:55:53 +0100, Emil Goode wrote: > > Hi Antonio, > >=20 > > The commit ed242d01 is in the linux-next tree and my patch depends on > > that commit. > >=20 >=20 > Yes, you are right. I was not aware of this commit, because the author > did not CC us (neither netdev) even if he changed the code we maintain. >=20 > As far as I can see that commit is in linux-next only. > Therefore it must be applied there. >=20 > However, I'd like you to change the commit message and write the full h= ash of > the commit you are referring to and its subject ("LIKE THIS"). This wou= ld make > it easier to find it. >=20 >=20 > Regards, >=20 > > Best regards, Emil > >=20 > > On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote: > > > Hi Emil, > > >=20 > > > On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote: > > > > The commit ed242d01 removed a node parameter from iterators. > > > > This patch removes a hlist_node struct that is no longer used. > > > >=20 > > > > Sparse gives a warning: > > > >=20 > > > > net/batman-adv/originator.c:411:21: warning: > > > > unused variable =E2=80=98node_tmp=E2=80=99 [-Wunused-variable] > > > >=20 > > > > Signed-off-by: Emil Goode > > >=20 > > > On which tree did you base your patch? > > > I cannot find the commit you are referring to (ed242d01) and the pa= tch does not > > > apply (neither on net nor net-next). > > >=20 > > > Other than that the variable is used a couple of lines below (in th= e code we > > > have)... > > >=20 > > > Regards, > > >=20 > >=20 > >=20 >=20