From: Shuah Khan <shuah.khan@hp.com>
To: Joerg Roedel <joro@8bytes.org>,
tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com
Cc: stable <stable@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Greg KH <gregkh@linuxfoundation.org>,
x86@kernel.org, shuahkhan@gmail.com
Subject: [PATCH] amd_iommu: IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init()
Date: Wed, 06 Feb 2013 19:53:23 -0700 [thread overview]
Message-ID: <1360205603.2615.19.camel@lorien2> (raw)
When dma_ops are initialized the unity mappings are created. The
init_device_table_dma() function makes sure DMA from all devices is
blocked by default. This opens a short window in time where DMA to
unity mapped regions is blocked by the IOMMU. Make sure this does not
happen by initializing the device table after dma_ops.
Reference: http://www.gossamer-threads.com/lists/linux/kernel/1670769
Signed-off-by: Shuah Khan <shuah.khan@hp.com>
CC: stable@vger.kernel.org 3.0
---
arch/x86/kernel/amd_iommu_init.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 33df6e8..d86aa3f 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -1363,6 +1363,7 @@ static struct syscore_ops amd_iommu_syscore_ops = {
*/
static int __init amd_iommu_init(void)
{
+ struct amd_iommu *iommu;
int i, ret = 0;
/*
@@ -1411,9 +1412,6 @@ static int __init amd_iommu_init(void)
if (amd_iommu_pd_alloc_bitmap == NULL)
goto free;
- /* init the device table */
- init_device_table();
-
/*
* let all alias entries point to itself
*/
@@ -1463,6 +1461,12 @@ static int __init amd_iommu_init(void)
if (ret)
goto free_disable;
+ /* init the device table */
+ init_device_table();
+
+ for_each_iommu(iommu)
+ iommu_flush_all_caches(iommu);
+
amd_iommu_init_api();
amd_iommu_init_notifier();
--
1.7.9.5
next reply other threads:[~2013-02-07 2:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 2:53 Shuah Khan [this message]
2013-02-07 10:49 ` [PATCH] amd_iommu: IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() Ingo Molnar
[not found] ` <20130207104905.GC8945-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-07 11:07 ` Joerg Roedel
2013-02-07 11:12 ` [v3.0 backport patch] " Ingo Molnar
2013-02-26 23:36 ` [PATCH 3.0] iommu/amd: Initialize device table after dma_ops Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2013-02-07 2:45 [PATCH] amd_iommu: IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360205603.2615.19.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=mingo@redhat.com \
--cc=shuahkhan@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.