From: Jan Stancek <jstancek@redhat.com>
To: Jeffrey Bastian <jbastian@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] use inotify_init1(0) for inotify tests on aarch64
Date: Thu, 6 Feb 2014 07:40:32 -0500 (EST) [thread overview]
Message-ID: <136022909.5430461.1391690432110.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20140204224400.GA8297@tarantula.localdomain>
----- Original Message -----
> From: "Jeffrey Bastian" <jbastian@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Tuesday, 4 February, 2014 11:44:00 PM
> Subject: [LTP] [PATCH] use inotify_init1(0) for inotify tests on aarch64
>
> aarch64 (and possibly other new architectures) does not implement
> the __ARCH_WANT_SYSCALL_NO_FLAGS syscalls, so use inotify_init1(0)
> instead of inotify_init(void)
>
> Signed-off-by: Jeffrey Bastian <jbastian@redhat.com>
Looks good to me.
Reviewed-by: Jan Stancek <jstancek@redhat.com>
Regards,
Jan
> ---
> testcases/kernel/syscalls/inotify/inotify.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/inotify/inotify.h
> b/testcases/kernel/syscalls/inotify/inotify.h
> index e396947c4f98..68fe3b5f6426 100644
> --- a/testcases/kernel/syscalls/inotify/inotify.h
> +++ b/testcases/kernel/syscalls/inotify/inotify.h
> @@ -30,8 +30,13 @@
>
> /* inotify(7) wrappers */
>
> +#if __NR_inotify_init != __LTP__NR_INVALID_SYSCALL
> #define myinotify_init() \
> syscall(__NR_inotify_init)
> +#else
> +#define myinotify_init() \
> + syscall(__NR_inotify_init1, 0)
> +#endif
>
> #define myinotify_add_watch(fd, pathname, mask) \
> syscall(__NR_inotify_add_watch, fd, pathname, mask)
> --
> 1.8.3.1
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-02-06 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 22:44 [LTP] [PATCH] use inotify_init1(0) for inotify tests on aarch64 Jeffrey Bastian
2014-02-06 12:40 ` Jan Stancek [this message]
2014-02-11 13:31 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=136022909.5430461.1391690432110.JavaMail.root@redhat.com \
--to=jstancek@redhat.com \
--cc=jbastian@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.