All of lore.kernel.org
 help / color / mirror / Atom feed
From: dirac3000@gmail.com (Alvaro Moran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] DMA: PL330: allow submitting 2 requests at a time
Date: Thu,  7 Feb 2013 11:38:43 +0100	[thread overview]
Message-ID: <1360233523-20825-1-git-send-email-dirac3000@gmail.com> (raw)

Due to the original driver design, only one request was processed at a
time by the driver, even if the low-level part of the driver was able to
handle 2 requests.
With this patch we are able to create 2 microcodes per thread and to
launch the second transfer on the interrupt handler of the first one,
instead of having to wait for the tasklet to generate the microcode.

Signed-off-by: Alvaro Moran <dirac3000@gmail.com>
---
 drivers/dma/pl330.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 80680ee..7814f8e 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -486,6 +486,8 @@ struct pl330_thread {
 	/* Index of the last submitted request or -1 if the DMA is stopped */
 	int req_running;
 };
+/* We handle two requests at a time */
+#define NR_MAX_REQUESTS	2
 
 enum pl330_dmac_state {
 	UNINIT,
@@ -2276,13 +2278,18 @@ static inline void handle_cyclic_desc_list(struct list_head *list)
 static inline void fill_queue(struct dma_pl330_chan *pch)
 {
 	struct dma_pl330_desc *desc;
+	int busy_reqs = 0;
 	int ret;
 
 	list_for_each_entry(desc, &pch->work_list, node) {
 
 		/* If already submitted */
-		if (desc->status == BUSY)
-			break;
+		if (desc->status == BUSY) {
+			busy_reqs++;
+			if (busy_reqs == NR_MAX_REQUESTS)
+				break;
+			continue;
+		}
 
 		ret = pl330_submit_req(pch->pl330_chid,
 						&desc->req);
-- 
1.7.10.4

             reply	other threads:[~2013-02-07 10:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 10:38 Alvaro Moran [this message]
2013-02-07 11:31 ` [PATCH 1/1] DMA: PL330: allow submitting 2 requests at a time Jassi Brar
2013-02-07 13:46   ` dirac3000
2013-02-07 14:12     ` Jassi Brar
2013-02-07 17:08       ` dirac3000
2013-02-13 10:12         ` dirac3000

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360233523-20825-1-git-send-email-dirac3000@gmail.com \
    --to=dirac3000@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.