From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIq9e-0006ed-Bz for mharc-grub-devel@gnu.org; Wed, 25 Aug 2021 06:29:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIq9c-0006eU-Mn for grub-devel@gnu.org; Wed, 25 Aug 2021 06:29:08 -0400 Received: from mout.gmx.net ([212.227.15.19]:46157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIq9a-0000nr-Rd for grub-devel@gnu.org; Wed, 25 Aug 2021 06:29:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629887345; bh=vMau7ZjL+VqeEiB1DrzhsUnPHO4XOjgEsXi+UQkaKhs=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc; b=VhW4Pg0oV7rjJIWeVBH/aigqdTG0QefSHjeccd9NrWvI2feTumT5DfX3qhiACEXYL tuKoP1ekrYN03aMMRHOateaorlCZgYsHUUwpo62dubi7y08UJN6DUXif8CEMfZFMNC 47CQ0L4qS41wutK4goTHxIkpJGp5qz5GoI7Dk6xQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.233.243]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfJd-1nAf1y0GVD-00vAIh for ; Wed, 25 Aug 2021 12:29:05 +0200 Date: Wed, 25 Aug 2021 12:29:48 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: [grub-fs-tester.in] zisofs test looks unsuitable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: development@efficientek.com Message-Id: <13604360919200184315@scdbackup.webframe.org> X-Provags-ID: V03:K1:9fOR57ZUGlbPlxqdVV7xTuA5UHZwYW8bZ4EsBn8nV/NfD/tzvdu Zfp3uziy+R98/l8YqwN6N/EQuCkHhIZc1BXbUfPF5szL7GCLSOphYQIudXvzX/w3GrDgXJn lXq5kTwQc8Z43yHAZRl15rDBWdA67IyqQ77XwAQiZaH3djRNzIIE68HYk+o6wm7Mfo78onE 3+skX2tJMfwSCsbzdgI/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:EBUS7ODf9uo=:GMZ/QOaTgLGi5e+Kk975q2 wcvkYepWQ1xuwcbMlO1Y98Ysyox1ihVNs2HNmo0J4KUmAmLpgQJFjKhB5hhGKWb+7QXpdS6VZ V/5MU7VQwQxJHv+xutOiYVT+ujQpyyRqBL8qmJQfMKayBELCq8owebzbKIMT7d5/0P+Y3/86z a8v91kEs7nziTNPAukVf+lWYh7UL6suUBGYLIkAl7gwrlZn19ZLWv/eE1/AfH6mHOmlbbRhtv EPzAeTr4VPYpE3Hjq/POyMyc3vIgL9zrRplTFOCk6s5o9KLlVuAtkQP7vrrOzUrsJYi7tF9kX BtzZD3CuAzXxRupZiUBaRxtGF2eosIt2EIWBc2SQEVJ1WL0Sk1N+zer6EKqG7tM5/Q3mjVuYj joibRe5eER/6igOCgRJGftSuLoVaM5HBoRu/S1T3eaNKh8hBG6Kix+QWAgHx+BLUvDq42NkgX H/DtxjFLm3Oa/ADTApXH723iHEDqOrA6Ldr9c5LBaJyFckeou+1ge7SuJUO2mKiYl3yo2A5e4 i9UWtPh4pxSipfXVukZAFrXaiC1z63zZRFrdG3pj3AzvM6vLMbf4oZx0kus9Nj5m+VOrx+7n7 6oi/PmmSzgHS4tmVL8bMyvNpJ5xQ7S+NdeUw+nrMr9psaaBprZczjuT+aXGJaL9D/eivBSqX7 lH6ygKJ9pFNMpNkA9nx7BpxfJvhq5igaFVp/QYDmt3sl4mMRhAqFPP1zIHXqmM8AreLYFMqz0 zViXCpIOApOMW8ZqCKUEvkkqeoS4vl8yLNO5SFQ+jfZihKIW7oW6BVGE0cuogMRAYvuHXqTMf 6xyAkZFq0vbNeGi9hgUdz8RvPBWGAciIezj5iuAqBm1lKJC2s8m01T9qzwigRaOxG1RJikBDZ bXjYX7yV59xF8Y3bgbtISNwJIZDGAbCVmeIo8B6L4Yk7QdEKPzghsIqdYRCZqk4RpR44FMuMA FFsfAKjD8zNerjwijFo+SoyLyx5RglhlH9xT48zsN+nYDNQHl+n1zudqQGLv1ix0BE+DnA2Ke g5GZaPCeyaCROMeQfz7pgFCZaTcaErcxxiIITypwEAS2M0E7z+b8/W0667GSskPsGN6sPSaOU V9oNCwoyj4oWr//BwltpvUg8SzMq9l5pdZPzw9m9Rgd4hEuPx0Vf70vVg== Received-SPF: pass client-ip=212.227.15.19; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2021 10:29:08 -0000 Hi, the xorriso run for testing zisofs in tests/util/grub-fs-tester.in looks not like it would cause any zisofs compression in the ISO. Line 1024: xorriso -compliance rec_mtime -set_filter_r --zisofs -- -zisofs defa= ult -as mkisofs ... some options ... -- -set_filter_r --zisofs -- -zisofs default -add /=3D"$MASTER"= ;; should probably become xorriso -compliance rec_mtime \ -as mkisofs ... same options as above ... -- \ -add /=3D"$MASTER" -- \ -zisofs default \ -set_filter_r --zisofs / -- ;; In the current run, both times when "-set_filter_r --zisofs" is executed in xorriso's native command mode, the emerging root directory is still emp= ty. So -set_filter_r cannot yet affect the files of "$MASTER" which get added only later. Command -zisofs sets parameters for -set_filter_r. So it must be executed before any successful -set_filter_r. Only the lack of any installed compression filters keeps the existing run from failing with libisofs: FAILURE : Cannot set global zisofs parameters while filters ex= ist Further: Command -set_filter_r expects one or more paths in the ISO as parameters. The empty path list defaults to "/" indeed, but that's not a documented feature. Command -add has a variable length parameter list and should thus be terminated by '--'. In my proposal it has to be terminated because more commands follow. Experiment: Currently the run is essentially like xorriso -compliance rec_mtime \ -as mkisofs -o test.iso --graft-points -- \ -add /=3Dtest -- -set_filter_r --zisofs / -- My test directory contains -rw-r--r-- 1 thomas thomas 51200 Aug 25 11:51 zeros -rw-r--r-- 1 thomas thomas 6 Aug 25 09:37 =C3=84=C3=96=C3=9C=C3=9F No zisofs compression gets applied by above run to the files, as can be seen by a subsequent run of xorriso -indev test.iso -find / -exec show_stream -- which reports '/zeros' < image:'/zeros' '/=C3=84=C3=96=C3=9C=C3=9F' < image:'/=C3=84=C3=96=C3=9C=C3=9F' In contrast, my proposed xorriso run causes compression of file "zeros", which then causes the xorriso run with -indev to install a decompression filter to that file: '/zeros' < --zisofs-decode:pz:32k < image:'/zeros' '/=C3=84=C3=96=C3=9C=C3=9F' < image:'/=C3=84=C3=96=C3=9C=C3=9F' The small "=C3=84=C3=96=C3=9C=C3=9F" staid uncompressed, because compressi= on yielded no gain in terms of 2048 byte blocks. Have a nice day :) Thomas