From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-trivial] [PATCH] ide: log error when trying to use ATAPI overlapping features
Date: Sun, 10 Feb 2013 23:12:11 +0100 [thread overview]
Message-ID: <1360534332-6549-1-git-send-email-hpoussin@reactos.org> (raw)
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/ide/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 3743dc3..f0ab1a8 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val)
break;
case WIN_PACKETCMD:
/* overlapping commands not supported */
- if (s->feature & 0x02)
+ if (s->feature & 0x02) {
+ qemu_log_mask(LOG_UNIMP, "ide: overlapping command not supported");
goto abort_cmd;
+ }
s->status = READY_STAT | SEEK_STAT;
s->atapi_dma = s->feature & 1;
s->nsector = 1;
--
1.7.10.4
next reply other threads:[~2013-02-10 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 22:12 Hervé Poussineau [this message]
2013-02-11 13:27 ` [Qemu-trivial] [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features Stefan Hajnoczi
2013-02-11 13:33 ` Kevin Wolf
2013-02-11 14:01 ` Markus Armbruster
2013-02-11 14:19 ` Andreas Färber
2013-02-11 14:34 ` Peter Maydell
2013-02-11 14:57 ` Stefan Hajnoczi
2013-02-11 15:03 ` Peter Maydell
2013-02-11 15:10 ` Andreas Färber
2013-02-12 7:55 ` Stefan Hajnoczi
2013-02-11 15:10 ` Peter Maydell
2013-02-11 21:08 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360534332-6549-1-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.