From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
chaitanyatk@posedge.com, linux-wireless@vger.kernel.org,
maheshp@posedge.com
Subject: Re: [RFC] mac80211: Add support for Tx-AMSDU viz debugfs.
Date: Mon, 11 Feb 2013 09:46:57 +0100 [thread overview]
Message-ID: <1360572417.8738.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CABPxzYLY5-MmePjUUGedC4rT88b328u7AKOeHREuF11BuOjYGA@mail.gmail.com> (sfid-20130211_085523_217176_1B4FC070)
On Mon, 2013-02-11 at 13:24 +0530, Krishna Chaitanya wrote:
> On Thu, Feb 7, 2013 at 8:57 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Thu, 2013-02-07 at 16:18 +0100, Felix Fietkau wrote:
> >
> >> > But whats the use of sending an AMSDU if we are not connected?
> >> > First check in the code is to check for a connection.
> >> I mentioned cooked monitor because putting the hw in monitor mode may
> >> not always be desirable, and cooked monitor bypasses that.
> >
> > You can pass "flags none" on the iw command line and it shouldn't change
> > much then, but yeah, still might do a few other things. Anyway cooked
> > should work fine.
>
> Even in the cooked monitor case, the setting of qos_header is done
> in the ieee80211_xmit(), so we still need to have some flag to know
> if its an AMSDU/Not based, even if we set the bit in the user space
> this will overwrite that.
You should be able to patch this very easily to preserve the A-MSDU bit,
which won't matter in the normal case where it's always cleared.
johannes
next prev parent reply other threads:[~2013-02-11 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 8:01 [RFC] mac80211: Add support for Tx-AMSDU viz debugfs chaitanyatk
2013-02-07 8:20 ` Johannes Berg
2013-02-07 9:19 ` Krishna Chaitanya
2013-02-07 9:23 ` Johannes Berg
2013-02-07 9:30 ` Krishna Chaitanya
2013-02-07 14:03 ` Felix Fietkau
2013-02-07 14:17 ` Johannes Berg
2013-02-07 14:57 ` Krishna Chaitanya
2013-02-07 15:18 ` Felix Fietkau
2013-02-07 15:27 ` Johannes Berg
2013-02-11 7:54 ` Krishna Chaitanya
2013-02-11 8:46 ` Johannes Berg [this message]
2013-02-11 9:28 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360572417.8738.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=chaitanyatk@posedge.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshp@posedge.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.