All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH 3/3] mac80211: generate mesh probe responses
Date: Mon, 11 Feb 2013 22:20:45 +0100	[thread overview]
Message-ID: <1360617645.8738.42.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360616843-24618-3-git-send-email-thomas@cozybit.com> (sfid-20130211_220850_670177_78A066DA)

On Mon, 2013-02-11 at 13:07 -0800, Thomas Pedersen wrote:

> +	if (elems.mesh_id_len != 0 &&
> +	    (elems.mesh_id_len != ifmsh->mesh_id_len ||
> +	     memcmp(elems.mesh_id, ifmsh->mesh_id, ifmsh->mesh_id_len))) {
> +		mpl_dbg(sdata, "ignoring probe request for different MBSS\n");

> +	presp = dev_alloc_skb(local->tx_headroom +
> +			      bcn->head_len + bcn->tail_len);
> +	if (WARN_ON(!presp))
> +		goto out;

same as before.


> +	mpl_dbg(sdata, "sending probe resp. to %pM\n", hdr->da);

I also think you should probably drop both mpl_dbg() statements as
they're likely to just be noise for any other debugging when you
actually use this?

johannes


  reply	other threads:[~2013-02-11 21:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 21:07 [PATCH 1/3] mac80211: consolidate MBSS change notification Thomas Pedersen
2013-02-11 21:07 ` [PATCH 2/3] mac80211: cache mesh beacon Thomas Pedersen
2013-02-11 21:17   ` Johannes Berg
2013-02-11 21:24     ` Thomas Pedersen
2013-02-11 21:34       ` Johannes Berg
2013-02-11 21:07 ` [PATCH 3/3] mac80211: generate mesh probe responses Thomas Pedersen
2013-02-11 21:20   ` Johannes Berg [this message]
2013-02-11 22:11     ` Thomas Pedersen
2013-02-12 17:56 ` [PATCH 1/3] mac80211: consolidate MBSS change notification Marco Porsch
2013-02-12 18:23   ` Thomas Pedersen
  -- strict thread matches above, loose matches on Subject: below --
2013-02-03  1:02 [PATCH 0/3] implement active mesh scanning Thomas Pedersen
2013-02-03  1:02 ` [PATCH 3/3] mac80211: generate mesh probe responses Thomas Pedersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360617645.8738.42.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=devel@lists.open80211s.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=thomas@cozybit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.