From: Tanu Kaskinen <tanuk@iki.fi>
To: David Henningsson <david.henningsson@canonical.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, 1109298@bugs.launchpad.net
Subject: Re: [PATCH] alsa-lib: Add sys/types.h to include list
Date: Tue, 12 Feb 2013 11:21:06 +0200 [thread overview]
Message-ID: <1360660866.18048.14.camel@laptop> (raw)
In-Reply-To: <1360659971-3852-1-git-send-email-david.henningsson@canonical.com>
On Tue, 2013-02-12 at 10:06 +0100, David Henningsson wrote:
> This is needed by snd_pcm_format_silence* functions which
> return u_int*_t. It was discovered while trying to compile ALSA
> programs with eglibc 2.17.
>
> Credits to Richard Shaw, Gary Buhrmaster, Matthieu Baerts and
> Adam Conrad for this fix.
>
> BugLink: https://bugs.launchpad.net/bugs/1109298
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=885306
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
> include/asoundlib-head.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asoundlib-head.h b/include/asoundlib-head.h
> index 20c8a68..6edbab0 100644
> --- a/include/asoundlib-head.h
> +++ b/include/asoundlib-head.h
> @@ -31,6 +31,7 @@
> #include <unistd.h>
> #include <stdio.h>
> #include <stdlib.h>
> +#include <sys/types.h>
int*_t and uint*_t (not u_int*_t) are standard in C99, and they are
available in stdint.h or inttypes.h (both work, inttypes.h contains also
the PRI* constants for the corresponding printf() format specifiers).
Perhaps it would be better to use one of those headers instead? That
would require converting u_int*_t usage to uint*_t, though, so it would
take some extra work...
--
Tanu
prev parent reply other threads:[~2013-02-12 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 9:06 [PATCH] alsa-lib: Add sys/types.h to include list David Henningsson
2013-02-12 9:10 ` Takashi Iwai
2013-02-12 9:16 ` David Henningsson
2013-02-12 9:21 ` Takashi Iwai
2013-02-12 9:21 ` Tanu Kaskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360660866.18048.14.camel@laptop \
--to=tanuk@iki.fi \
--cc=1109298@bugs.launchpad.net \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.