From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <coelho@ti.com>
Cc: linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [PATCH] cfg80211: check vendor IE length to avoid overrun
Date: Wed, 13 Feb 2013 10:15:17 +0100 [thread overview]
Message-ID: <1360746917.8868.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360692698-24208-1-git-send-email-coelho@ti.com>
On Tue, 2013-02-12 at 20:11 +0200, Luciano Coelho wrote:
> cfg80211_find_vendor_ie() was checking only that the vendor IE would
> fit in the remaining IEs buffer. If a corrupt includes a vendor IE
> that is too small, we could potentially overrun the IEs buffer.
>
> Fix this by checking that the vendor IE fits in the reported IE length
> field and skip it otherwise.
Applied. I changed the BUILD_BUG_ON to be != 1 since it has to be that,
but if one breaks that ...
johannes
next prev parent reply other threads:[~2013-02-13 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 18:11 [PATCH] cfg80211: check vendor IE length to avoid overrun Luciano Coelho
2013-02-13 9:15 ` Johannes Berg [this message]
2013-02-13 9:22 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360746917.8868.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.