From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincent Guittot <vincent.guittot@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH 2/3] sched: Move idle_balance() to post_schedule
Date: Wed, 13 Feb 2013 19:43:01 +0100 [thread overview]
Message-ID: <1360780981.8957.3.camel@laptop> (raw)
In-Reply-To: <20130212230017.625583020@goodmis.org>
On Tue, 2013-02-12 at 17:54 -0500, Steven Rostedt wrote:
> There's no real reason that the idle_balance() needs to be called in
> the
> middle of schedule anyway. The only benefit is that if a task is
> pulled
> to this CPU, it can be scheduled without the need to schedule the idle
> task.
Uhm, istr that extra schedule being an issue somewhere.. Make very sure
you don't regress anything silly like sysbench or hackbench. Maybe ask
Mike, he seems to have a better retention for benchmark weirdness than
me.
> But load balancing and migrating the task makes a switch to idle
> and back negligible.
How does that follow? We can have to-idle switches _far_ more often than
we balance.
next prev parent reply other threads:[~2013-02-13 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 22:54 [PATCH 0/3] [GIT PULL] sched: clean ups and a minor fix Steven Rostedt
2013-02-12 22:54 ` [PATCH 1/3] sched/rt: Fix push_rt_task() to have the same checks as the caller did Steven Rostedt
2013-02-12 22:54 ` [PATCH 2/3] sched: Move idle_balance() to post_schedule Steven Rostedt
2013-02-13 18:43 ` Peter Zijlstra [this message]
2013-02-13 19:05 ` Steven Rostedt
2013-02-15 11:51 ` Peter Zijlstra
2013-02-15 13:37 ` Steven Rostedt
2013-02-14 14:25 ` Steven Rostedt
2013-02-12 22:54 ` [PATCH 3/3] sched: Enable interrupts in idle_balance() Steven Rostedt
2013-02-13 8:33 ` [PATCH 0/3] [GIT PULL] sched: clean ups and a minor fix Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360780981.8957.3.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.