From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH v2 2/3] mac80211: cache mesh beacon
Date: Thu, 14 Feb 2013 12:18:50 +0100 [thread overview]
Message-ID: <1360840730.8210.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360786461-30107-2-git-send-email-thomas@cozybit.com> (sfid-20130213_211540_930271_3D0A9A30)
On Wed, 2013-02-13 at 12:14 -0800, Thomas Pedersen wrote:
> Previously, the entire mesh beacon would be generated each
> time the beacon timer fired. Instead generate a beacon
> head and tail (so the TIM can easily be inserted when mesh
> power save is on) when starting a mesh or the MBSS
> parameters change.
>
> Also add a mutex for protecting beacon updates and
> preventing leaks.
And I dropped the patch again due to a sparse warning (with RCU sparse
enabled in Kconfig):
net/mac80211/mesh.c:836:9: warning: incorrect type in argument 1 (different address spaces)
net/mac80211/mesh.c:836:9: expected struct callback_head *head
net/mac80211/mesh.c:836:9: got struct callback_head [noderef] <asn:4>*<noident>
(btw, should there be locking there in that function?)
johannes
next prev parent reply other threads:[~2013-02-14 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 20:14 [PATCH v2 1/3] mac80211: consolidate MBSS change notification Thomas Pedersen
2013-02-13 20:14 ` [PATCH v2 2/3] mac80211: cache mesh beacon Thomas Pedersen
2013-02-14 11:18 ` Johannes Berg [this message]
2013-02-14 18:10 ` Thomas Pedersen
2013-02-14 11:57 ` Marco Porsch
2013-02-14 17:48 ` Thomas Pedersen
2013-02-13 20:14 ` [PATCH v2 3/3] mac80211: generate mesh probe responses Thomas Pedersen
2013-02-13 22:52 ` [PATCH v2 1/3] mac80211: consolidate MBSS change notification Johannes Berg
2013-02-13 23:11 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360840730.8210.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.