From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Wojciech.Dubowik@neratec.com
Subject: Re: [PATCH v2] mac80211: fix auth/assoc timeout handling
Date: Thu, 14 Feb 2013 18:29:48 +0100 [thread overview]
Message-ID: <1360862988.8210.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360834178-11599-1-git-send-email-johannes@sipsolutions.net> (sfid-20130214_103000_695358_DC6C573F)
On Thu, 2013-02-14 at 10:29 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> In my commit 1672c0e31917f49d31d30d79067103432bc20cc7
> ("mac80211: start auth/assoc timeout on frame status")
> I broke auth/assoc timeout handling: in case we wait
> for the TX status, it now leaves the timeout field set
> to 0, which is a valid time and can compare as being
> before now ("jiffies"). Thus, if the work struct runs
> for some other reason, the auth/assoc is treated as
> having timed out.
>
> Fix this by introducing a separate "timeout_started"
> variable that tracks whether the timeout has started
> and is checked before timing out.
>
> Additionally, for proper TX status handling the change
> requires that the skb->dev pointer is set up for all
> the frames, so set it up for all frames in mac80211.
Applied.
johannes
prev parent reply other threads:[~2013-02-14 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 9:29 [PATCH v2] mac80211: fix auth/assoc timeout handling Johannes Berg
2013-02-14 10:50 ` Wojciech Dubowik
2013-02-14 11:05 ` Johannes Berg
2013-02-14 11:01 ` Wojciech Dubowik
2013-02-14 17:29 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360862988.8210.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Wojciech.Dubowik@neratec.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.