All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
	Vlad Yasevich <vyasevic@redhat.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v4] netpoll: fix some sparse warnings in various places
Date: Mon, 18 Feb 2013 10:55:26 +0800	[thread overview]
Message-ID: <1361156126.5967.8.camel@cr0> (raw)
In-Reply-To: <20130216091808.GA1536@minipsycho.orion>

On Sat, 2013-02-16 at 10:18 +0100, Jiri Pirko wrote:
> 
> Hmm. I'm just wondering if there wouldn't be nicer for these functions
> to
> return bool if you just want to know if npinfo is null or not. This
> notation seems a bit confusing to me. 

Yes, makes sense.

      reply	other threads:[~2013-02-18  2:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16  8:37 [Patch net-next v4] netpoll: fix some sparse warnings in various places Cong Wang
2013-02-16  9:18 ` Jiri Pirko
2013-02-18  2:55   ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361156126.5967.8.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.