All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: netfilter-devel@vger.kernel.org
Cc: eric@regit.org
Subject: [PATCH 6/7] logemu: return error if configuration is invalid.
Date: Mon, 18 Feb 2013 09:37:47 +0100	[thread overview]
Message-ID: <1361176668-22661-7-git-send-email-eric@regit.org> (raw)
In-Reply-To: <1361176668-22661-1-git-send-email-eric@regit.org>


Signed-off-by: Eric Leblond <eric@regit.org>
---
 output/ulogd_output_LOGEMU.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/output/ulogd_output_LOGEMU.c b/output/ulogd_output_LOGEMU.c
index 26f139b..bb27209 100644
--- a/output/ulogd_output_LOGEMU.c
+++ b/output/ulogd_output_LOGEMU.c
@@ -177,11 +177,8 @@ static int fini_logemu(struct ulogd_pluginstance *pi) {
 static int configure_logemu(struct ulogd_pluginstance *pi,
 			    struct ulogd_pluginstance_stack *stack)
 {
-	/* FIXME: error handling */
 	ulogd_log(ULOGD_DEBUG, "parsing config file section %s\n", pi->id);
-	config_parse_file(pi->id, pi->config_kset);
-
-	return 0;
+	return config_parse_file(pi->id, pi->config_kset);
 }
 
 static struct ulogd_plugin logemu_plugin = { 
-- 
1.7.10.4


  parent reply	other threads:[~2013-02-18  8:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  8:37 [ulogd patch] small code cleaning Eric Leblond
2013-02-18  8:37 ` [PATCH 1/7] Update TODO Eric Leblond
2013-02-18  8:37 ` [PATCH 2/7] Suppress dead FIXME Eric Leblond
2013-02-18  8:37 ` [PATCH 3/7] Use access to ensure readability of config gile Eric Leblond
2013-02-18  8:37 ` [PATCH 4/7] Fix typo in comments Eric Leblond
2013-02-18  8:37 ` [PATCH 5/7] Add handling of too long arguments Eric Leblond
2013-02-18  9:41   ` Mr Dash Four
2013-02-18 15:04     ` Eric Leblond
2013-02-18  8:37 ` Eric Leblond [this message]
2013-02-18  8:37 ` [PATCH 7/7] conf: error handling for too long line Eric Leblond
2013-02-18  9:41   ` Mr Dash Four
2013-02-22 10:18 ` [ulogd patch] small code cleaning Eric Leblond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361176668-22661-7-git-send-email-eric@regit.org \
    --to=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.